Bug 181042 - Do not reuse resource for memory cache if selected service worker differs
Summary: Do not reuse resource for memory cache if selected service worker differs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 09:32 PST by Chris Dumez
Modified: 2017-12-20 10:32 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.10 KB, patch)
2017-12-20 09:38 PST, Chris Dumez 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-20 09:32:46 PST 
Do not reuse resource for memory cache if selected service worker differs.
Comment 1 Chris Dumez 2017-12-20 09:38:20 PST 
Created attachment 329926 [details]
Patch
Comment 2 youenn fablet 2017-12-20 10:10:39 PST 
Comment on attachment 329926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329926&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:1028
> +    if (cachedResourceRequest.options().serviceWorkerIdentifier != existingResource->options().serviceWorkerIdentifier) {

I think we should add a comment or a FIXME to state that this area is under specified and that we should try specificying/validating this with other browsers.
Now it feels safer to do that to limit weird bugs/flakinesses.
Comment 3 Chris Dumez 2017-12-20 10:30:11 PST 
Committed r226188: <https://trac.webkit.org/changeset/226188>
Comment 4 Radar WebKit Bug Importer 2017-12-20 10:32:26 PST 
<rdar://problem/36158813>