Bug 181035 - Support service worker interception of request with blob body
Summary: Support service worker interception of request with blob body
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 08:04 PST by youenn fablet
Modified: 2017-12-20 11:18 PST (History)
8 users (show)

See Also:


Attachments
Patch (20.04 KB, patch)
2017-12-20 08:08 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.57 MB, application/zip)
2017-12-20 09:19 PST, Build Bot
no flags Details
Patch for landing (21.99 KB, patch)
2017-12-20 10:43 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-20 08:04:58 PST
Support service worker interception of request with blob body
Comment 1 youenn fablet 2017-12-20 08:08:53 PST
Created attachment 329921 [details]
Patch
Comment 2 Build Bot 2017-12-20 09:19:31 PST
Comment on attachment 329921 [details]
Patch

Attachment 329921 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5774711

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html
Comment 3 Build Bot 2017-12-20 09:19:32 PST
Created attachment 329925 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 youenn fablet 2017-12-20 10:07:25 PST
Comment on attachment 329921 [details]
Patch

Test failure is unrelated.
Comment 5 Chris Dumez 2017-12-20 10:14:47 PST
Comment on attachment 329921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329921&action=review

> Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74
> +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck)

Coding style says we need a prefix for such boolean variables, maybe shouldBypassConnectionCheck ?
Comment 6 youenn fablet 2017-12-20 10:43:05 PST
Created attachment 329933 [details]
Patch for landing
Comment 7 youenn fablet 2017-12-20 10:43:39 PST
(In reply to Chris Dumez from comment #5)
> Comment on attachment 329921 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329921&action=review
> 
> > Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74
> > +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess* connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool bypassConnectionCheck)
> 
> Coding style says we need a prefix for such boolean variables, maybe
> shouldBypassConnectionCheck ?

Done in landing patch.
Comment 8 WebKit Commit Bot 2017-12-20 11:16:14 PST
Comment on attachment 329933 [details]
Patch for landing

Clearing flags on attachment: 329933

Committed r226191: <https://trac.webkit.org/changeset/226191>
Comment 9 WebKit Commit Bot 2017-12-20 11:16:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-20 11:18:46 PST
<rdar://problem/36160201>