RESOLVED FIXED 181034
Replace a FIXME comment in CanvasGradient::addColorStop(). 
https://bugs.webkit.org/show_bug.cgi?id=181034
Summary Replace a FIXME comment in CanvasGradient::addColorStop().
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-12-20 07:33:22 PST
.
Attachments
Patch (1.58 KB, patch)
2017-12-20 07:37 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2017-12-21 06:18 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-12-20 07:37:13 PST
Created attachment 329917 [details] Patch
Daniel Bates
Comment 2 2017-12-20 12:45:12 PST
Comment on attachment 329917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329917&action=review > Source/WebCore/html/canvas/CanvasGradient.cpp:51 > + // Passing null for canvas ensures that currentColor is treated as black, > + // as required by the standard. > Color color = parseColorOrCurrentColor(colorString, nullptr /*canvas*/); The updated comment is good. Even better would be a layout test to both document this behavior and ensure we do not regress it. Do we have an existing test? If not, please write one.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2017-12-21 05:50:49 PST
LayoutTests/imported/w3c/canvas/2d.gradient.object.current.html is checking this and passing.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2017-12-21 06:18:03 PST
Created attachment 330030 [details] Patch
WebKit Commit Bot
Comment 5 2017-12-21 06:51:53 PST
Comment on attachment 330030 [details] Patch Clearing flags on attachment: 330030 Committed r226220: <https://trac.webkit.org/changeset/226220>
WebKit Commit Bot
Comment 6 2017-12-21 06:51:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-21 06:52:43 PST
<rdar://problem/36177424>
Note You need to log in before you can comment on or make changes to this bug.