Bug 181018 - [RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTable::addChild to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from Rende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 21:40 PST by zalan
Modified: 2017-12-20 08:53 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.57 KB, patch)
2017-12-19 21:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.54 KB, patch)
2017-12-20 07:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-12-19 21:40:53 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2017-12-19 21:41:18 PST 
<rdar://problem/36148601>
Comment 2 zalan 2017-12-19 21:46:13 PST 
Created attachment 329896 [details]
Patch
Comment 3 Antti Koivisto 2017-12-20 06:16:25 PST 
Comment on attachment 329896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329896&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:66
> +        auto& parentCandidate = m_tableBuilder->findOrCreateParentForChild(downcast<RenderTableRow>(parent), *child, beforeChild);

I added tableBuilder() helper, you can use that (probably also why this doesn't merge).
Comment 4 zalan 2017-12-20 07:17:34 PST 
Created attachment 329916 [details]
Patch
Comment 5 WebKit Commit Bot 2017-12-20 08:53:03 PST 
Comment on attachment 329916 [details]
Patch

Clearing flags on attachment: 329916

Committed r226181: <https://trac.webkit.org/changeset/226181>
Comment 6 WebKit Commit Bot 2017-12-20 08:53:04 PST 
All reviewed patches have been landed.  Closing bug.