Bug 181014 - MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing
Summary: MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 17:31 PST by Daniel Bates
Modified: 2017-12-20 12:00 PST (History)
3 users (show)

See Also:

Attachments
Patch and unit test (6.62 KB, patch)
2017-12-20 11:29 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-12-19 17:31:33 PST 
From <https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2063/steps/run-api-tests/logs/stdio>:

[[
FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmost

/Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:193
Value of: results[i]
  Actual: (50, 60, GrammarError)
Expected: expectedSubranges[i]
Which is: (50, 60, Selection)

FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmostWithLongestEffectiveRange

/Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:208
Value of: results.size()
  Actual: 3
Expected: expectedSubranges.size()
Which is: 2
]]
Comment 1 Daniel Bates 2017-12-19 17:34:38 PST 
Temporarily disabled running the tests and committed this in <https://trac.webkit.org/changeset/226165>.
Comment 2 Daniel Bates 2017-12-20 11:29:30 PST 
Created attachment 329938 [details]
Patch and unit test
Comment 3 EWS Watchlist 2017-12-20 11:31:41 PST 
Attachment 329938 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/MarkerSubrange.cpp:100:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Daniel Bates 2017-12-20 11:59:39 PST 
Comment on attachment 329938 [details]
Patch and unit test

Clearing flags on attachment: 329938

Committed r226194: <https://trac.webkit.org/changeset/226194>
Comment 5 Daniel Bates 2017-12-20 11:59:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-20 12:00:34 PST 
<rdar://problem/36161355>