RESOLVED FIXED 181014
MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing 
https://bugs.webkit.org/show_bug.cgi?id=181014
Summary MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLo...
Daniel Bates
Reported 2017-12-19 17:31:33 PST
From <https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2063/steps/run-api-tests/logs/stdio>: [[ FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmost /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:193 Value of: results[i] Actual: (50, 60, GrammarError) Expected: expectedSubranges[i] Which is: (50, 60, Selection) FAIL MarkerSubrange.SubdivideGrammarAndSelectionOverlapFrontmostWithLongestEffectiveRange /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:208 Value of: results.size() Actual: 3 Expected: expectedSubranges.size() Which is: 2 ]]
Attachments
Patch and unit test (6.62 KB, patch)
2017-12-20 11:29 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-12-19 17:34:38 PST
Temporarily disabled running the tests and committed this in <https://trac.webkit.org/changeset/226165>.
Daniel Bates
Comment 2 2017-12-20 11:29:30 PST
Created attachment 329938 [details] Patch and unit test
EWS Watchlist
Comment 3 2017-12-20 11:31:41 PST
Attachment 329938 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/MarkerSubrange.cpp:100: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 4 2017-12-20 11:59:39 PST
Comment on attachment 329938 [details] Patch and unit test Clearing flags on attachment: 329938 Committed r226194: <https://trac.webkit.org/changeset/226194>
Daniel Bates
Comment 5 2017-12-20 11:59:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-20 12:00:34 PST
<rdar://problem/36161355>
Note You need to log in before you can comment on or make changes to this bug.