Bug 181005 - Web Inspector: add TestPage.debug() to inspect evaluations being sent to Inspector page
Summary: Web Inspector: add TestPage.debug() to inspect evaluations being sent to Insp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 15:41 PST by BJ Burg
Modified: 2018-01-04 12:38 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2017-12-19 15:42 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-12-19 15:41:03 PST
I used this once and I liked it.
Comment 1 BJ Burg 2017-12-19 15:42:51 PST
Created attachment 329842 [details]
Patch
Comment 2 Joseph Pecoraro 2017-12-19 15:44:23 PST
Comment on attachment 329842 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2017-12-19 16:06:47 PST
Comment on attachment 329842 [details]
Patch

Clearing flags on attachment: 329842

Committed r226155: <https://trac.webkit.org/changeset/226155>
Comment 4 WebKit Commit Bot 2017-12-19 16:06:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-19 16:07:20 PST
<rdar://problem/36143853>
Comment 6 Matt Lewis 2017-12-20 16:43:47 PST
This patch has caused a layout test to start failing consistently on macOS WK2 Debug testers:

Test: http/tests/inspector/network/har/har-page.html


https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html


build:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r226199%20(1886)/results.html


diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -87,7 +87,7 @@
             "size": 0,
             "compression": 0,
             "mimeType": "application/x-javascript",
-            "text": "<filtered text (6707)>"
+            "text": "<filtered text (7039)>"
           },
           "redirectURL": "",
           "headersSize": "<filtered>",
Comment 7 Matt Lewis 2017-12-20 17:49:05 PST
Reverted r226155 for reason:

This caused test failures.

Committed r226207: <https://trac.webkit.org/changeset/226207>
Comment 8 Joseph Pecoraro 2017-12-20 18:23:11 PST
All that was needed was a rebase...
Comment 9 BJ Burg 2018-01-04 12:38:11 PST
Committed r226414: <https://trac.webkit.org/changeset/226414>