Bug 181005 – Web Inspector: add TestPage.debug() to inspect evaluations being sent to Inspector page

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

I used this once and I liked it.

[Blaze Burg]

Created attachment 329842 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 329842 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 329842 [details]
Patch

Clearing flags on attachment: 329842

Committed r226155: <https://trac.webkit.org/changeset/226155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36143853>

[Matt Lewis]

This patch has caused a layout test to start failing consistently on macOS WK2 Debug testers:

Test: http/tests/inspector/network/har/har-page.html


https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html


build:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r226199%20(1886)/results.html


diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -87,7 +87,7 @@
             "size": 0,
             "compression": 0,
             "mimeType": "application/x-javascript",
-            "text": "<filtered text (6707)>"
+            "text": "<filtered text (7039)>"
           },
           "redirectURL": "",
           "headersSize": "<filtered>",

[Matt Lewis]

Reverted r226155 for reason:

This caused test failures.

Committed r226207: <https://trac.webkit.org/changeset/226207>

[Joseph Pecoraro]

All that was needed was a rebase...

[Blaze Burg]

Committed r226414: <https://trac.webkit.org/changeset/226414>