Bug 181000 - ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
Summary: ServiceWorkerThreadProxy should set the correct cookie and cache partitioning...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 14:25 PST by youenn fablet
Modified: 2017-12-21 21:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (57.67 KB, patch)
2017-12-19 14:31 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (58.17 KB, patch)
2017-12-19 15:15 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (58.10 KB, patch)
2017-12-21 21:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-19 14:25:56 PST 
In addition, service worker frame loader client should allow using credentials
Comment 1 youenn fablet 2017-12-19 14:31:53 PST 
Created attachment 329827 [details]
Patch
Comment 2 youenn fablet 2017-12-19 15:15:09 PST 
Created attachment 329838 [details]
Patch
Comment 3 Chris Dumez 2017-12-20 09:05:10 PST 
Comment on attachment 329838 [details]
Patch

Seems fine but it'd be good if Brady or Alex had a look.
Comment 4 Brady Eidson 2017-12-20 14:49:45 PST 
Comment on attachment 329838 [details]
Patch

seems fine-ish
Comment 5 WebKit Commit Bot 2017-12-21 12:19:13 PST 
Comment on attachment 329838 [details]
Patch

Rejecting attachment 329838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 329838, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in
patching file Source/WebKitLegacy/mac/Misc/WebCache.mm
patching file LayoutTests/imported/w3c/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5791458
Comment 6 youenn fablet 2017-12-21 21:01:11 PST 
Created attachment 330105 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-12-21 21:36:17 PST 
Comment on attachment 330105 [details]
Patch for landing

Clearing flags on attachment: 330105

Committed r226257: <https://trac.webkit.org/changeset/226257>
Comment 8 WebKit Commit Bot 2017-12-21 21:36:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-12-21 21:37:23 PST 
<rdar://problem/36190807>