Bug 180999 - Standardize terminology for marked text
Summary: Standardize terminology for marked text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 14:17 PST by Daniel Bates
Modified: 2018-02-27 14:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (79.73 KB, patch)
2017-12-19 14:21 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (79.83 KB, patch)
2017-12-19 14:41 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (87.49 KB, patch)
2018-02-23 16:59 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (87.56 KB, patch)
2018-02-23 17:03 PST, Daniel Bates 		zalan: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (11.54 MB, application/zip)
2018-02-23 18:59 PST, EWS Watchlist 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-12-19 14:17:05 PST 
Standardize terminology for marked text.
Comment 1 Daniel Bates 2017-12-19 14:21:32 PST 
Created attachment 329824 [details]
Patch
Comment 2 Daniel Bates 2017-12-19 14:41:57 PST 
Created attachment 329833 [details]
Patch
Comment 3 Daniel Bates 2018-02-23 16:59:01 PST 
Created attachment 334554 [details]
Patch
Comment 4 EWS Watchlist 2018-02-23 17:01:48 PST 
Attachment 334554 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/MarkedText.cpp:92:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:565:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Daniel Bates 2018-02-23 17:03:02 PST 
Created attachment 334555 [details]
Patch
Comment 6 EWS Watchlist 2018-02-23 17:04:59 PST 
Attachment 334555 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/MarkedText.cpp:92:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:565:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 EWS Watchlist 2018-02-23 18:58:59 PST 
Comment on attachment 334555 [details]
Patch

Attachment 334555 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6648038

New failing tests:
http/wpt/resource-timing/rt-initiatorType-media.html
Comment 8 EWS Watchlist 2018-02-23 18:59:10 PST 
Created attachment 334560 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Daniel Bates 2018-02-26 12:00:07 PST 
(In reply to Build Bot from comment #7)
> Comment on attachment 334555 [details]
> Patch
> 
> Attachment 334555 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/6648038
> 
> New failing tests:
> http/wpt/resource-timing/rt-initiatorType-media.html

I am unclear how this test failure could be caused by this rename patch.
Comment 10 Daniel Bates 2018-02-27 14:35:57 PST 
Committed r229079: <https://trac.webkit.org/changeset/229079>
Comment 11 Radar WebKit Bug Importer 2018-02-27 14:37:09 PST 
<rdar://problem/37957482>