Bug 180992 - Move first-letter building code to RenderTreeBuilder
Summary: Move first-letter building code to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 13:20 PST by Antti Koivisto
Modified: 2017-12-19 17:45 PST (History)
5 users (show)

See Also:

Attachments
patch (52.50 KB, patch)
2017-12-19 13:25 PST, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (52.50 KB, patch)
2017-12-19 13:47 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (52.92 KB, patch)
2017-12-19 15:18 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-12-19 13:20:20 PST 
RenderTreeBuilder should deal with all special case tree mutations.
Comment 1 Antti Koivisto 2017-12-19 13:25:50 PST 
Created attachment 329803 [details]
patch
Comment 2 zalan 2017-12-19 13:30:22 PST 
Comment on attachment 329803 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329803&action=review

> Source/WebCore/ChangeLog:8
> +        All special case tree building logic should go to RenderTreeBuilder.s

awesome extension!
Comment 3 Antti Koivisto 2017-12-19 13:47:48 PST 
Created attachment 329809 [details]
patch
Comment 4 Antti Koivisto 2017-12-19 15:18:22 PST 
Created attachment 329840 [details]
patch
Comment 5 WebKit Commit Bot 2017-12-19 17:44:41 PST 
Comment on attachment 329840 [details]
patch

Clearing flags on attachment: 329840

Committed r226168: <https://trac.webkit.org/changeset/226168>
Comment 6 WebKit Commit Bot 2017-12-19 17:44:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-19 17:45:27 PST 
<rdar://problem/36145846>