Bug 180987 - We forgot to do index masking for in bounds int32 arrays in the FTL
Summary: We forgot to do index masking for in bounds int32 arrays in the FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 12:28 PST by Saam Barati
Modified: 2017-12-20 00:25 PST (History)
8 users (show)

See Also:


Attachments
patch (1.87 KB, patch)
2017-12-19 12:29 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-19 12:28:56 PST
....
Comment 1 Saam Barati 2017-12-19 12:29:38 PST
Created attachment 329792 [details]
patch
Comment 2 Keith Miller 2017-12-19 12:30:41 PST
Comment on attachment 329792 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2017-12-19 13:51:30 PST
Comment on attachment 329792 [details]
patch

Clearing flags on attachment: 329792

Committed r226139: <https://trac.webkit.org/changeset/226139>
Comment 4 WebKit Commit Bot 2017-12-19 13:51:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-19 13:52:33 PST
<rdar://problem/36139961>
Comment 6 Yusuke Suzuki 2017-12-20 00:25:15 PST
This introduces 15.4% regression in Octane/crypto. It seems indexing masking cause very large overhead. Can we have a way to alleviate it?