Bug 180977 - API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
Summary: API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAtta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 09:39 PST by Ryan Haddad
Modified: 2017-12-19 15:13 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.20 KB, patch)
2017-12-19 12:10 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2017-12-19 12:28 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2017-12-19 12:33 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.92 KB, patch)
2017-12-19 13:00 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-12-19 09:39:54 PST 
API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/6490/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/4696/steps/run-api-tests/logs/stdio

2017-12-19 08:45:50.300 TestWebKitAPI[3218:23049405] Encountered error: Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=TypeError: undefined is not an object (evaluating 'document.querySelectorAll('attachment')[2].getAttribute'), WKJavaScriptExceptionSourceURL=file:///Volumes/Data/slave/elcapitan-debug-tests-wk1/build/WebKitBuild/Debug/TestWebKitAPI.resources/, NSLocalizedDescription=A JavaScript exception occurred, WKJavaScriptExceptionColumnNumber=43} while evaluating script: document.querySelectorAll('attachment')[2].getAttribute('type')
FAIL WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments

/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:858
Value of: observer.observer().inserted.count
  Actual: 2
Expected: 3U
Which is: 3


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:870
Value of: zipAttachment && imageAttachment && pdfAttachment
  Actual: false
Expected: true


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:871
Value of: [webView stringByEvaluatingJavaScript:@"document.querySelectorAll('attachment').length"].integerValue
  Actual: 2
Expected: 3


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:249
Value of: !error
  Actual: false
Expected: true


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:874
Value of: [webView stringByEvaluatingJavaScript:@"document.querySelectorAll('attachment')[2].getAttribute('type')"]
  Actual: "(null)"
Expected: "application/zip"


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:881
Value of: removedAttachments.count
  Actual: 2
Expected: 3U
Which is: 3


/Volumes/Data/slave/elcapitan-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:882
Value of: [removedAttachments containsObject:zipAttachment.get()]
  Actual: false
Expected: true
Comment 1 Alexey Proskuryakov 2017-12-19 10:07:42 PST 
Failing every time since added in https://trac.webkit.org/r226093
Comment 2 Wenson Hsieh 2017-12-19 12:10:57 PST 
Created attachment 329787 [details]
Patch
Comment 3 Wenson Hsieh 2017-12-19 12:28:22 PST 
Created attachment 329791 [details]
Patch
Comment 4 Wenson Hsieh 2017-12-19 12:33:34 PST 
Created attachment 329794 [details]
Patch
Comment 5 Wenson Hsieh 2017-12-19 13:00:28 PST 
Created attachment 329799 [details]
Patch
Comment 6 WebKit Commit Bot 2017-12-19 15:12:04 PST 
Comment on attachment 329799 [details]
Patch

Clearing flags on attachment: 329799

Committed r226148: <https://trac.webkit.org/changeset/226148>
Comment 7 WebKit Commit Bot 2017-12-19 15:12:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-19 15:13:42 PST 
<rdar://problem/36142337>