Bug 180976 - Do not search for service worker registration in case of non HTTP navigation loads
Summary: Do not search for service worker registration in case of non HTTP navigation ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 09:17 PST by youenn fablet
Modified: 2017-12-20 13:51 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2017-12-19 09:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.32 KB, patch)
2017-12-19 09:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2017-12-19 15:12 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing spaces (2.17 KB, patch)
2017-12-20 13:30 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-19 09:17:30 PST 
Do not search for service workers in case of non HTTP main frame navigation loads.
Comment 1 youenn fablet 2017-12-19 09:18:48 PST 
Created attachment 329765 [details]
Patch
Comment 2 youenn fablet 2017-12-19 09:23:00 PST 
Created attachment 329766 [details]
Patch
Comment 3 youenn fablet 2017-12-19 15:12:49 PST 
Created attachment 329837 [details]
Patch
Comment 4 WebKit Commit Bot 2017-12-20 09:22:39 PST 
Comment on attachment 329837 [details]
Patch

Clearing flags on attachment: 329837

Committed r226185: <https://trac.webkit.org/changeset/226185>
Comment 5 WebKit Commit Bot 2017-12-20 09:22:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-20 09:23:27 PST 
<rdar://problem/36157322>
Comment 7 Tim Horton 2017-12-20 13:24:08 PST 
Comment on attachment 329837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329837&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1573
> +        auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled()            && SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying());

What’s going on with all the weird spaces?
Comment 8 youenn fablet 2017-12-20 13:28:26 PST 
Comment on attachment 329837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329837&action=review

>> Source/WebCore/loader/DocumentLoader.cpp:1573
>> +        auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled()            && SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying());
> 
> What’s going on with all the weird spaces?

Will fix it.
Comment 9 youenn fablet 2017-12-20 13:30:35 PST 
Reopening to attach new patch.
Comment 10 youenn fablet 2017-12-20 13:30:35 PST 
Created attachment 329949 [details]
Fixing spaces
Comment 11 WebKit Commit Bot 2017-12-20 13:51:42 PST 
Comment on attachment 329949 [details]
Fixing spaces

Clearing flags on attachment: 329949

Committed r226200: <https://trac.webkit.org/changeset/226200>
Comment 12 WebKit Commit Bot 2017-12-20 13:51:44 PST 
All reviewed patches have been landed.  Closing bug.