Bug 180969 – Don't convert pasted content to use blob URL in WebKit1

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

Turns out there are some WebKit1 clients that depend on the URL of the pasted content
being differentiable between file & http URLs. In addition, https://webkit.org/b/178947
makes it impossible to retrieve the file contents right now.

Restore the behavior prior to https://trac.webkit.org/changeset/223440 in WebKit1 to unbreak these clients.

[Ryosuke Niwa]

Created attachment 329823 [details]
Restores the old behavior

[Ryosuke Niwa]

<rdar://problem/36019793>

[Wenson Hsieh]

Comment on attachment 329823 [details]
Restores the old behavior

View in context: https://bugs.webkit.org/attachment.cgi?id=329823&action=review

> Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125
> +    destinationWebView.get().frameLoadDelegate = delegate.get();

Nit - we usually write using bracket notation (as [destinationWebView setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for the other places in this file)

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 329823 [details]
> Restores the old behavior
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329823&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125
> > +    destinationWebView.get().frameLoadDelegate = delegate.get();
> 
> Nit - we usually write using bracket notation (as [destinationWebView
> setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for
> the other places in this file)

Fixed.

Thanks for the review.

[Ryosuke Niwa]

Committed r226156: <https://trac.webkit.org/changeset/226156>