Bug 180969 - Don't convert pasted content to use blob URL in WebKit1
Summary: Don't convert pasted content to use blob URL in WebKit1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 01:51 PST by Ryosuke Niwa
Modified: 2017-12-19 16:07 PST (History)
1 user (show)

See Also:

Attachments
Restores the old behavior (19.71 KB, patch)
2017-12-19 14:18 PST, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-12-19 01:51:06 PST 
Turns out there are some WebKit1 clients that depend on the URL of the pasted content
being differentiable between file & http URLs. In addition, https://webkit.org/b/178947
makes it impossible to retrieve the file contents right now.

Restore the behavior prior to https://trac.webkit.org/changeset/223440 in WebKit1 to unbreak these clients.
Comment 1 Ryosuke Niwa 2017-12-19 14:18:51 PST 
Created attachment 329823 [details]
Restores the old behavior
Comment 2 Ryosuke Niwa 2017-12-19 14:30:53 PST 
<rdar://problem/36019793>
Comment 3 Wenson Hsieh 2017-12-19 14:41:46 PST 
Comment on attachment 329823 [details]
Restores the old behavior

View in context: https://bugs.webkit.org/attachment.cgi?id=329823&action=review

> Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125
> +    destinationWebView.get().frameLoadDelegate = delegate.get();

Nit - we usually write using bracket notation (as [destinationWebView setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for the other places in this file)
Comment 4 Ryosuke Niwa 2017-12-19 15:08:45 PST 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 329823 [details]
> Restores the old behavior
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329823&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125
> > +    destinationWebView.get().frameLoadDelegate = delegate.get();
> 
> Nit - we usually write using bracket notation (as [destinationWebView
> setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for
> the other places in this file)

Fixed.

Thanks for the review.
Comment 5 Ryosuke Niwa 2017-12-19 16:07:34 PST 
Committed r226156: <https://trac.webkit.org/changeset/226156>