Bug 180962 - UserMediaRequest should stop a request when Document is being stopped
Summary: UserMediaRequest should stop a request when Document is being stopped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-18 18:28 PST by youenn fablet
Modified: 2017-12-19 19:20 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.95 KB, patch)
2017-12-18 18:30 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.87 MB, application/zip)
2017-12-18 19:37 PST, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (14.34 MB, application/zip)
2017-12-18 19:45 PST, Build Bot
no flags Details
Patch (4.26 KB, patch)
2017-12-19 13:02 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Rebasing (7.43 KB, patch)
2017-12-19 18:43 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-12-18 18:28:54 PST
MediaStream and MediaStreamTrack should unregister from Document in their stop methods
Comment 1 youenn fablet 2017-12-18 18:30:07 PST
Created attachment 329721 [details]
Patch
Comment 2 Build Bot 2017-12-18 19:37:37 PST
Comment on attachment 329721 [details]
Patch

Attachment 329721 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5738257

New failing tests:
webrtc/video.html
webrtc/video-autoplay.html
fast/mediastream/media-stream-track-muted.html
fast/mediastream/media-stream-track-source-failure.html
webrtc/getUserMedia-webaudio-autoplay.html
Comment 3 Build Bot 2017-12-18 19:37:38 PST
Created attachment 329728 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-12-18 19:45:44 PST
Comment on attachment 329721 [details]
Patch

Attachment 329721 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5738171

New failing tests:
webrtc/video.html
webrtc/video-autoplay.html
platform/ios/mediastream/video-muted-in-background-tab.html
webrtc/getUserMedia-webaudio-autoplay.html
Comment 5 Build Bot 2017-12-18 19:45:45 PST
Created attachment 329730 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 6 youenn fablet 2017-12-19 13:02:29 PST
Created attachment 329801 [details]
Patch
Comment 7 youenn fablet 2017-12-19 18:43:20 PST
Created attachment 329871 [details]
Rebasing
Comment 8 WebKit Commit Bot 2017-12-19 19:17:28 PST
Comment on attachment 329871 [details]
Rebasing

Clearing flags on attachment: 329871

Committed r226171: <https://trac.webkit.org/changeset/226171>
Comment 9 WebKit Commit Bot 2017-12-19 19:17:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-19 19:20:46 PST
<rdar://problem/36147248>