RESOLVED FIXED 180960
[DFG][FTL] NewRegexp shoud be fast 
https://bugs.webkit.org/show_bug.cgi?id=180960
Summary [DFG][FTL] NewRegexp shoud be fast
Yusuke Suzuki
Reported 2017-12-18 17:59:04 PST
This patch is one of the series of optimizing the case, string.match(/regexp/) thing. When evaluating /regexp/, new RegExpObject is created every time. However, basically, we do not have much interest on this object. At the end of the patch series, we should make this PhantomNewRegexp in OAS phase. As a first step of these NewRegexp optimization, we would like to inline it by using allocateJSObject.
Attachments
Patch (12.71 KB, patch)
2017-12-19 03:53 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (18.13 KB, patch)
2017-12-19 04:55 PST, Yusuke Suzuki 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-12-19 03:53:35 PST
Created attachment 329753 [details] Patch
Yusuke Suzuki
Comment 2 2017-12-19 04:55:27 PST
Created attachment 329756 [details] Patch
Michael Saboff
Comment 3 2017-12-19 11:13:52 PST
Comment on attachment 329756 [details] Patch Nice r=me
Yusuke Suzuki
Comment 4 2017-12-19 11:36:36 PST
(In reply to Michael Saboff from comment #3) > Comment on attachment 329756 [details] > Patch > > Nice > r=me Thank you for your review!
Yusuke Suzuki
Comment 5 2017-12-19 11:38:37 PST
Committed r226134: <https://trac.webkit.org/changeset/226134>
Radar WebKit Bug Importer
Comment 6 2017-12-19 11:39:24 PST
<rdar://problem/36136719>
Note You need to log in before you can comment on or make changes to this bug.