Bug 180956 - Web Inspector: InspectorTest.evaluateInPage should return a rejection if an error was thrown
Summary: Web Inspector: InspectorTest.evaluateInPage should return a rejection if an e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-18 16:13 PST by BJ Burg
Modified: 2017-12-19 17:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.80 KB, patch)
2017-12-18 16:16 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch v2 (20.66 KB, patch)
2017-12-18 16:34 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch v2 (6.82 KB, patch)
2017-12-18 16:34 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch v2 (20.66 KB, patch)
2017-12-18 16:47 PST, BJ Burg 		joepeck: review-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-12-18 16:13:59 PST 
This is definitely what's most convenient when writing tests. async function will turn this into a thrown error that causes everything to blow up rather than silently fail.
Comment 1 BJ Burg 2017-12-18 16:16:51 PST 
Created attachment 329704 [details]
Patch
Comment 2 BJ Burg 2017-12-18 16:34:05 PST 
Created attachment 329705 [details]
Patch v2
Comment 3 BJ Burg 2017-12-18 16:34:27 PST 
Created attachment 329706 [details]
Patch v2
Comment 4 Joseph Pecoraro 2017-12-18 16:42:33 PST 
Comment on attachment 329706 [details]
Patch v2

r=me
Comment 5 BJ Burg 2017-12-18 16:47:05 PST 
Created attachment 329712 [details]
Patch v2
Comment 6 Joseph Pecoraro 2017-12-19 15:51:44 PST 
r- this appears to be the wrong patch.
Comment 7 BJ Burg 2017-12-19 16:32:49 PST 
Comment on attachment 329706 [details]
Patch v2

webkit-patch strikes again...
Comment 8 Joseph Pecoraro 2017-12-19 16:50:55 PST 
Comment on attachment 329706 [details]
Patch v2

r=me
Comment 9 WebKit Commit Bot 2017-12-19 17:30:01 PST 
Comment on attachment 329706 [details]
Patch v2

Clearing flags on attachment: 329706

Committed r226163: <https://trac.webkit.org/changeset/226163>
Comment 10 WebKit Commit Bot 2017-12-19 17:30:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-12-19 17:31:21 PST 
<rdar://problem/36145581>