180951 – A disallowed user-installed font may be used if its PostScript name is specified

RESOLVED FIXED 180951

A disallowed user-installed font may be used if its PostScript name is specified

https://bugs.webkit.org/show_bug.cgi?id=180951

Summary A disallowed user-installed font may be used if its PostScript name is specified

Myles C. Maxfield

Reported 2017-12-18 15:24:56 PST

A disallowed user-installed font may be used if its PostScript name is specified

Attachments
Patch (2.31 KB, patch) 2017-12-18 15:25 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (6.38 KB, patch) 2017-12-18 16:16 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (27.55 KB, patch) 2017-12-18 17:24 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (43.73 KB, patch) 2017-12-18 20:45 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (43.80 KB, patch) 2017-12-18 20:46 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (44.43 KB, patch) 2017-12-18 21:06 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (43.60 KB, patch) 2017-12-19 11:15 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (39.20 KB, patch) 2017-12-19 11:38 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (39.26 KB, patch) 2017-12-19 12:00 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (46.44 KB, patch) 2017-12-19 15:55 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.37 KB, patch) 2017-12-19 19:41 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.37 KB, patch) 2017-12-19 19:41 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.37 KB, patch) 2017-12-19 19:47 PST, Myles C. Maxfield	bfulgham: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for committing (13.40 KB, patch) 2018-01-29 16:52 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-12-18 15:25:45 PST

Created attachment 329692 [details] Patch

Myles C. Maxfield

Comment 2 2017-12-18 16:16:37 PST

Created attachment 329703 [details] Patch

Myles C. Maxfield

Comment 3 2017-12-18 17:24:27 PST

Created attachment 329716 [details] Patch

Myles C. Maxfield

Comment 4 2017-12-18 20:45:24 PST

Created attachment 329735 [details] Patch

Myles C. Maxfield

Comment 5 2017-12-18 20:46:49 PST

Created attachment 329736 [details] Patch

Myles C. Maxfield

Comment 6 2017-12-18 20:49:48 PST

<rdar://problem/36029919>

Myles C. Maxfield

Comment 7 2017-12-18 21:06:04 PST

Created attachment 329738 [details] Patch

Myles C. Maxfield

Comment 8 2017-12-19 11:15:56 PST

Created attachment 329778 [details] Patch

Myles C. Maxfield

Comment 9 2017-12-19 11:38:37 PST

Created attachment 329780 [details] Patch

Myles C. Maxfield

Comment 10 2017-12-19 12:00:31 PST

Created attachment 329785 [details] Patch

Myles C. Maxfield

Comment 11 2017-12-19 15:55:25 PST

Created attachment 329847 [details] Patch

Myles C. Maxfield

Comment 12 2017-12-19 17:24:03 PST

This cause fast/text/user-installed-fonts/disable.html to pass.

Myles C. Maxfield

Comment 13 2017-12-19 19:41:01 PST

Created attachment 329877 [details] Patch

Myles C. Maxfield

Comment 14 2017-12-19 19:41:38 PST

Created attachment 329878 [details] Patch

Myles C. Maxfield

Comment 15 2017-12-19 19:47:30 PST

Created attachment 329880 [details] Patch

Brent Fulgham

Comment 16 2017-12-20 17:22:08 PST

Comment on attachment 329880 [details] Patch Looks good! r=me.

WebKit Commit Bot

Comment 17 2017-12-20 17:26:11 PST

Comment on attachment 329880 [details] Patch Rejecting attachment 329880 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 329880, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: cs/cocoa/FontCacheCoreText.cpp Hunk #1 FAILED at 908. Hunk #2 FAILED at 937. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp.rej patching file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h patching file Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5782477

Brent Fulgham

Comment 18 2018-01-02 11:59:26 PST

It looks like the patch is stale. Can you land manually, please?

Myles C. Maxfield

Comment 19 2018-01-05 16:30:10 PST

I need to wait for <rdar://problem/35895817>.

Myles C. Maxfield

Comment 20 2018-01-29 16:52:20 PST

Created attachment 332602 [details] Patch for committing

Myles C. Maxfield

Comment 21 2018-01-30 01:01:35 PST

Committed r227776: <https://trac.webkit.org/changeset/227776>

Myles C. Maxfield

Comment 22 2018-01-30 13:51:25 PST

Committed r227848: <https://trac.webkit.org/changeset/227848>

Myles C. Maxfield

Comment 23 2018-02-01 20:46:30 PST

Committed r227995: <https://trac.webkit.org/changeset/227995>

Myles C. Maxfield

Comment 24 2018-02-02 20:22:09 PST

Committed r228044: <https://trac.webkit.org/changeset/228044>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Myles C. Maxfield

Reported

2017-12-18 15:24 PST

Modified

2018-02-02 20:22 PST History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks