Bug 180951 - A disallowed user-installed font may be used if its PostScript name is specified
Summary: A disallowed user-installed font may be used if its PostScript name is specified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-18 15:24 PST by Myles C. Maxfield
Modified: 2018-02-02 20:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2017-12-18 15:25 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.38 KB, patch)
2017-12-18 16:16 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (27.55 KB, patch)
2017-12-18 17:24 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (43.73 KB, patch)
2017-12-18 20:45 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (43.80 KB, patch)
2017-12-18 20:46 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (44.43 KB, patch)
2017-12-18 21:06 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (43.60 KB, patch)
2017-12-19 11:15 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (39.20 KB, patch)
2017-12-19 11:38 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (39.26 KB, patch)
2017-12-19 12:00 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (46.44 KB, patch)
2017-12-19 15:55 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2017-12-19 19:41 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2017-12-19 19:41 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2017-12-19 19:47 PST, Myles C. Maxfield 		bfulgham: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (13.40 KB, patch)
2018-01-29 16:52 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-12-18 15:24:56 PST 
A disallowed user-installed font may be used if its PostScript name is specified
Comment 1 Myles C. Maxfield 2017-12-18 15:25:45 PST 
Created attachment 329692 [details]
Patch
Comment 2 Myles C. Maxfield 2017-12-18 16:16:37 PST 
Created attachment 329703 [details]
Patch
Comment 3 Myles C. Maxfield 2017-12-18 17:24:27 PST 
Created attachment 329716 [details]
Patch
Comment 4 Myles C. Maxfield 2017-12-18 20:45:24 PST 
Created attachment 329735 [details]
Patch
Comment 5 Myles C. Maxfield 2017-12-18 20:46:49 PST 
Created attachment 329736 [details]
Patch
Comment 6 Myles C. Maxfield 2017-12-18 20:49:48 PST 
<rdar://problem/36029919>
Comment 7 Myles C. Maxfield 2017-12-18 21:06:04 PST 
Created attachment 329738 [details]
Patch
Comment 8 Myles C. Maxfield 2017-12-19 11:15:56 PST 
Created attachment 329778 [details]
Patch
Comment 9 Myles C. Maxfield 2017-12-19 11:38:37 PST 
Created attachment 329780 [details]
Patch
Comment 10 Myles C. Maxfield 2017-12-19 12:00:31 PST 
Created attachment 329785 [details]
Patch
Comment 11 Myles C. Maxfield 2017-12-19 15:55:25 PST 
Created attachment 329847 [details]
Patch
Comment 12 Myles C. Maxfield 2017-12-19 17:24:03 PST 
This cause fast/text/user-installed-fonts/disable.html to pass.
Comment 13 Myles C. Maxfield 2017-12-19 19:41:01 PST 
Created attachment 329877 [details]
Patch
Comment 14 Myles C. Maxfield 2017-12-19 19:41:38 PST 
Created attachment 329878 [details]
Patch
Comment 15 Myles C. Maxfield 2017-12-19 19:47:30 PST 
Created attachment 329880 [details]
Patch
Comment 16 Brent Fulgham 2017-12-20 17:22:08 PST 
Comment on attachment 329880 [details]
Patch

Looks good! r=me.
Comment 17 WebKit Commit Bot 2017-12-20 17:26:11 PST 
Comment on attachment 329880 [details]
Patch

Rejecting attachment 329880 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 329880, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
cs/cocoa/FontCacheCoreText.cpp
Hunk #1 FAILED at 908.
Hunk #2 FAILED at 937.
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp.rej
patching file Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h
patching file Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5782477
Comment 18 Brent Fulgham 2018-01-02 11:59:26 PST 
It looks like the patch is stale. Can you land manually, please?
Comment 19 Myles C. Maxfield 2018-01-05 16:30:10 PST 
I need to wait for <rdar://problem/35895817>.
Comment 20 Myles C. Maxfield 2018-01-29 16:52:20 PST 
Created attachment 332602 [details]
Patch for committing
Comment 21 Myles C. Maxfield 2018-01-30 01:01:35 PST 
Committed r227776: <https://trac.webkit.org/changeset/227776>
Comment 22 Myles C. Maxfield 2018-01-30 13:51:25 PST 
Committed r227848: <https://trac.webkit.org/changeset/227848>
Comment 23 Myles C. Maxfield 2018-02-01 20:46:30 PST 
Committed r227995: <https://trac.webkit.org/changeset/227995>
Comment 24 Myles C. Maxfield 2018-02-02 20:22:09 PST 
Committed r228044: <https://trac.webkit.org/changeset/228044>