The tests typeProfiler/deltablue-for-of.js and typeProfiler/getter-richards.js take a very long time in the ftl-no-cjit-type-profiler-force-poly-proto on embedded platform, and thus always timeout. They should be skipped on these platforms.
Created attachment 329657 [details] Patch Patch skipping the tests on all arm and mips architectures.
Comment on attachment 329657 [details] Patch Informally reviewing: r+ This sounds reasonable to me, given that many ARM/MIPS based-devices readily available for development and actually running the tests tend to be SoC targeted to the embedded market which tend to be limited in memory, speed, or both.
Comment on attachment 329657 [details] Patch Clearing flags on attachment: 329657 Committed r226222: <https://trac.webkit.org/changeset/226222>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36260881>
<rdar://problem/36260882>
Comment on attachment 329657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329657&action=review > JSTests/typeProfiler/getter-richards.js:1 > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end Sorry for the 2 year old comment, but just for posterity, this test is wrong because it disables this from running on arm64
(In reply to Saam Barati from comment #7) > Comment on attachment 329657 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329657&action=review > > > JSTests/typeProfiler/getter-richards.js:1 > > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end > > Sorry for the 2 year old comment, but just for posterity, this test is wrong > because it disables this from running on arm64 "2 year old comment" => "comment on 2 year old patch"