Bug 180926 – [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Fujii Hironori]

[Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID

I tested with trunk@226017, WinCairo, Debug build.

1) Start MiniBrowser
2) Open http://google.com

> SHOULD NEVER BE REACHED
> C:\webkit\ga\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient.cpp(126) : WebFrameLoaderClient::pageID

Maybe caused by Bug 180682.

Callstack:

> WTF.dll!WTFCrash() Line 272	C++	Symbols loaded.
> WebKit.dll!WebFrameLoaderClient::pageID() Line 126	C++	Symbols loaded.
> WebKit.dll!WebCore::setCookies(WebCore::Document & document, const WebCore::URL & url, const WTF::String & cookieString) Line 80	C++	Symbols loaded.
> WebKit.dll!WebCore::Document::setCookie(const WTF::String & value) Line 4537	C++	Symbols loaded.
> WebKit.dll!WebCore::setJSDocumentCookieSetter::__l2::<lambda>() Line 1267	C++	Symbols loaded.
> WebKit.dll!WebCore::AttributeSetter::call<WebCore::ExceptionOr<void> <lambda>(void) >(JSC::ExecState & state, JSC::ThrowScope & throwScope, WebCore::setJSDocumentCookieSetter::__l2::WebCore::ExceptionOr<void> <lambda>(void) && functor) Line 104	C++	Symbols loaded.
> WebKit.dll!WebCore::setJSDocumentCookieSetter(JSC::ExecState & state, WebCore::JSDocument & thisObject, JSC::JSValue value, JSC::ThrowScope & throwScope) Line 1269	C++	Symbols loaded.
> WebKit.dll!WebCore::IDLAttribute<WebCore::JSDocument>::set<&WebCore::setJSDocumentCookieSetter,0>(JSC::ExecState & state, __int64 thisValue, __int64 encodedValue, const char * attributeName) Line 50	C++	Symbols loaded.
> WebKit.dll!WebCore::setJSDocumentCookie(JSC::ExecState * state, __int64 thisValue, __int64 encodedValue) Line 1275	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::callCustomSetter(JSC::ExecState * exec, bool(*)(JSC::ExecState *, __int64, __int64) setter, bool isAccessor, JSC::JSValue thisValue, JSC::JSValue value) Line 41	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::callCustomSetter(JSC::ExecState * exec, JSC::JSValue customGetterSetter, bool isAccessor, JSC::JSObject * base, JSC::JSValue thisValue, JSC::JSValue value) Line 59	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::JSObject::putInlineSlow(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 794	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::JSObject::putInlineForJSObject(JSC::JSCell * cell, JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 229	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::JSCell::putInline(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 374	C++	Symbols loaded.
> JavaScriptCore.dll!JSC::JSValue::putInline(JSC::ExecState * exec, JSC::PropertyName propertyName, JSC::JSValue value, JSC::PutPropertySlot & slot) Line 912	C++	Symbols loaded.
> JavaScriptCore.dll!llint_slow_path_put_by_id(JSC::ExecState * exec, JSC::Instruction * pc) Line 751	C++	Symbols loaded.
> [External Code]		Annotated Frame
> JavaScriptCore.dll!JSC::dateProtoFuncToUTCString(JSC::ExecState * exec) Line 535	C++	Symbols loaded.
> [External Code]		Annotated Frame

[Fujii Hironori]

RELEASE_ASSERT_NOT_REACHED of Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm was removed in r225934.

https://trac.webkit.org/changeset/225934/webkit#file28

[Fujii Hironori]

Created attachment 329644 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 329644 [details]
Patch

Clearing flags on attachment: 329644

Committed r226091: <https://trac.webkit.org/changeset/226091>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36121778>