Bug 180925 - [Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3
Summary: [Apple Pay] Only include phonetic name properties in ApplePayPaymentContact w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-17 21:12 PST by Andy Estes
Modified: 2017-12-18 21:39 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.56 KB, patch)
2017-12-17 21:16 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (36.92 KB, patch)
2017-12-17 21:33 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (22.66 KB, patch)
2017-12-18 21:18 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-12-17 21:12:27 PST 
[Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3
Comment 1 Andy Estes 2017-12-17 21:12:58 PST 
rdar://problem/35907596
Comment 2 Andy Estes 2017-12-17 21:16:10 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2017-12-17 21:18:07 PST Comment hidden (obsolete)
Comment 4 Andy Estes 2017-12-17 21:33:50 PST 
Created attachment 329637 [details]
Patch
Comment 5 EWS Watchlist 2017-12-17 21:35:17 PST 
Attachment 329637 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2017-12-18 13:27:24 PST 
Comment on attachment 329637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329637&action=review

> Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:188
> -		0F7EB7EF1F95285300F1ABCB /* libtestbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; name = libtestbmalloc; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; };
> +		0F7EB7EF1F95285300F1ABCB /* testbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; };

I think you got some Xcode crazy here.
Comment 7 Andy Estes 2017-12-18 21:18:13 PST 
Created attachment 329740 [details]
Patch
Comment 8 EWS Watchlist 2017-12-18 21:20:36 PST 
Attachment 329740 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2017-12-18 21:39:30 PST 
Comment on attachment 329740 [details]
Patch

Clearing flags on attachment: 329740

Committed r226098: <https://trac.webkit.org/changeset/226098>
Comment 10 WebKit Commit Bot 2017-12-18 21:39:31 PST 
All reviewed patches have been landed.  Closing bug.