RESOLVED FIXED 18091
font-size doesn't get animated using -webkit-transition
https://bugs.webkit.org/show_bug.cgi?id=18091
Summary font-size doesn't get animated using -webkit-transition
Benoit Marchant
Reported 2008-03-25 16:54:37 PDT
See the attached test case
Attachments
example of the bug (4.30 KB, application/xhtml+xml)
2008-03-25 17:03 PDT, Benoit Marchant
no flags
Support font-size animation (2.90 KB, patch)
2008-08-28 12:32 PDT, Dave Hyatt
darin: review+
Benoit Marchant
Comment 1 2008-03-25 17:03:46 PDT
Created attachment 20060 [details] example of the bug example of the bug
Dave Hyatt
Comment 2 2008-08-28 12:32:48 PDT
Created attachment 23058 [details] Support font-size animation
Darin Adler
Comment 3 2008-08-28 12:45:37 PDT
Comment on attachment 23058 [details] Support font-size animation + // FIXME: Use with caution. Only used for blending font sizes when animating. + void setFontSize(int size) { + FontDescription desc(fontDescription()); + desc.setSpecifiedSize(size); + desc.setComputedSize(size); + setFontDescription(desc); + font().update(font().fontSelector()); + } Since this function is only used through a function pointer, it's not helpful to inline it. So it would be better if this was in a .cpp file instead of the header. The comment says "caution" which I think is too vague. And it says FIXME without being clear what should be fixed. It would be stronger if this said something more like: // Used for blending font sizes when animating. // Would be a bad idea to use this in other cases because <reason header>. r=me, but please consider my comments and consider if you can add a test case
Dave Hyatt
Comment 4 2008-08-28 12:49:56 PDT
You can really only make manual tests for transitions, since we have no testing framework for them. :( I'll change the function name to setBlendedFontSize and remove the inlining.
Darin Adler
Comment 5 2008-10-12 15:15:21 PDT
Note You need to log in before you can comment on or make changes to this bug.