Bug 180901 - Hollow out stub implementation of InspectorBackendDispatcher::sendResponse().
Summary: Hollow out stub implementation of InspectorBackendDispatcher::sendResponse().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 180762
  Show dependency treegraph
 
Reported: 2017-12-15 19:42 PST by Mark Lam
Modified: 2017-12-17 17:05 PST (History)
8 users (show)

See Also:


Attachments
proposed patch. (53.90 KB, patch)
2017-12-15 23:10 PST, Mark Lam
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-12-15 19:42:31 PST
Patch coming.
Comment 1 Radar WebKit Bug Importer 2017-12-15 19:43:18 PST
<rdar://problem/36087649>
Comment 2 Joseph Pecoraro 2017-12-15 19:50:52 PST
I think we can entirely stub out InspectorValues here.

Older versions of System Safari used InspectorValues (via WebInspector.framework) for two things:

  • Augmented JSContexts SPIs (via WebInspector.framework)
    - not actually used
  • WebDriver (maybe?)
    - I don't think this can be used with SafariForWebKitDevelopment

Since neither are used when running SafariForWebKitDevelopment we can stub out the symbols (InspectorValues, InspectorObjects, InspectorBackendDispatcher::sendResponse) to do nothing, and SafariForWebKitDevelopment  will then continue to launch with a trunk WebKit and won't have any observable bad behavior.
Comment 3 Mark Lam 2017-12-15 23:10:13 PST
Created attachment 329563 [details]
proposed patch.
Comment 4 Mark Lam 2017-12-17 13:00:03 PST
Thanks for the review.  Landed in r226012: <http://trac.webkit.org/r226012>.
Comment 5 Joseph Pecoraro 2017-12-17 17:05:58 PST
Comment on attachment 329563 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=329563&action=review

Looks good!

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:189
>  // FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
>  void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result)

I still don't think this comment makes sense for this file. JSON::Object is new so I don't think any existing code can depend on it.

You may want to move the FIXME / bugzilla bug to the DeprecatedInspectorValues file.

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:90
>      // When <http://webkit.org/b/179847> is fixed or this class is renamed for the JSON::Object case,
>      // then this alternate method with a dummy parameter can be removed in favor of the one without it.

Same.