Bug 180901 – Hollow out stub implementation of InspectorBackendDispatcher::sendResponse().

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Radar WebKit Bug Importer]

<rdar://problem/36087649>

[Joseph Pecoraro]

I think we can entirely stub out InspectorValues here.

Older versions of System Safari used InspectorValues (via WebInspector.framework) for two things:

  • Augmented JSContexts SPIs (via WebInspector.framework)
    - not actually used
  • WebDriver (maybe?)
    - I don't think this can be used with SafariForWebKitDevelopment

Since neither are used when running SafariForWebKitDevelopment we can stub out the symbols (InspectorValues, InspectorObjects, InspectorBackendDispatcher::sendResponse) to do nothing, and SafariForWebKitDevelopment  will then continue to launch with a trunk WebKit and won't have any observable bad behavior.

[Mark Lam]

Created attachment 329563 [details]
proposed patch.

[Mark Lam]

Thanks for the review.  Landed in r226012: <http://trac.webkit.org/r226012>.

[Joseph Pecoraro]

Comment on attachment 329563 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=329563&action=review

Looks good!

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:189
>  // FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
>  void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result)

I still don't think this comment makes sense for this file. JSON::Object is new so I don't think any existing code can depend on it.

You may want to move the FIXME / bugzilla bug to the DeprecatedInspectorValues file.

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:90
>      // When <http://webkit.org/b/179847> is fixed or this class is renamed for the JSON::Object case,
>      // then this alternate method with a dummy parameter can be removed in favor of the one without it.

Same.