Bug 180900 - Web Inspector: Styles Redesign: Command-S should save changes in matching CSS resource
Summary: Web Inspector: Styles Redesign: Command-S should save changes in matching CSS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-15 18:53 PST by Nikita Vasilyev
Modified: 2017-12-18 15:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2017-12-15 18:57 PST, Nikita Vasilyev 		timothy: review+
Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2017-12-18 14:30 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-12-15 18:53:27 PST 
When focused on a CSS rule, Command-S should save the owner CSS resource the same way if we were to edit this CSS in Resources tab.

The legacy styles sidebar supported it.

<rdar://problem/35648633>
Comment 1 Nikita Vasilyev 2017-12-15 18:57:29 PST 
Created attachment 329555 [details]
Patch
Comment 2 Nikita Vasilyev 2017-12-15 19:02:57 PST 
This is essentially the same patch as it was for the old styles sidebar in 2015 Bug 150298 - Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file.
Comment 3 Timothy Hatcher 2017-12-18 13:25:14 PST 
Comment on attachment 329555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329555&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:407
> +            url = pathDirectory + "base64.css";

Why base64.css? data.css? WI.frameResourceManager.mainFrame.mainResource.url - ".html" + "-data.css"?
Comment 4 Nikita Vasilyev 2017-12-18 14:30:15 PST 
Created attachment 329684 [details]
Patch
Comment 5 WebKit Commit Bot 2017-12-18 15:02:43 PST 
Comment on attachment 329684 [details]
Patch

Clearing flags on attachment: 329684

Committed r226082: <https://trac.webkit.org/changeset/226082>
Comment 6 WebKit Commit Bot 2017-12-18 15:02:45 PST 
All reviewed patches have been landed.  Closing bug.