Bug 180891 - Add optimization when updating a SW registration results in the exact same script
Summary: Add optimization when updating a SW registration results in the exact same sc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 180888
Blocks:
  Show dependency tree / graph
 
Reported: 2017-12-15 16:20 PST by Chris Dumez
Modified: 2017-12-16 10:45 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.40 KB, patch)
2017-12-15 16:25 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.40 KB, patch)
2017-12-15 16:48 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (3.01 MB, application/zip)
2017-12-15 17:56 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (19.82 MB, application/zip)
2017-12-15 18:23 PST, EWS Watchlist 		no flags Details
Patch (19.23 KB, patch)
2017-12-15 19:24 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-15 16:20:39 PST 
Add optimization when updating a SW registration results in the exact same script:
- https://w3c.github.io/ServiceWorker/#update-algorithm (step 8)
Comment 1 Chris Dumez 2017-12-15 16:25:41 PST 
Created attachment 329537 [details]
Patch
Comment 2 Chris Dumez 2017-12-15 16:48:58 PST 
Created attachment 329541 [details]
Patch
Comment 3 EWS Watchlist 2017-12-15 17:56:10 PST 
Comment on attachment 329541 [details]
Patch

Attachment 329541 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5679354

New failing tests:
http/tests/workers/service/registration-updateViaCache-imports-importScripts.html
http/tests/workers/service/self_registration_update.html
http/tests/workers/service/service-worker-registration-gc-event.html
http/tests/workers/service/registration-updateViaCache-none-importScripts.html
http/tests/workers/service/registration-updateViaCache-all-importScripts.html
http/tests/workers/service/registration-updateViaCache-all.html
http/tests/workers/service/controller-change.html
Comment 4 EWS Watchlist 2017-12-15 17:56:11 PST 
Created attachment 329550 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 EWS Watchlist 2017-12-15 18:23:21 PST 
Comment on attachment 329541 [details]
Patch

Attachment 329541 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5679473

New failing tests:
http/tests/workers/service/registration-updateViaCache-imports-importScripts.html
http/tests/workers/service/self_registration_update.html
http/tests/workers/service/service-worker-registration-gc-event.html
http/tests/workers/service/registration-updateViaCache-none-importScripts.html
http/tests/workers/service/controller-change.html
http/tests/workers/service/registration-updateViaCache-all.html
http/tests/workers/service/registration-updateViaCache-all-importScripts.html
Comment 6 EWS Watchlist 2017-12-15 18:23:23 PST 
Created attachment 329553 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 7 Chris Dumez 2017-12-15 19:24:55 PST 
Created attachment 329556 [details]
Patch
Comment 8 Geoffrey Garen 2017-12-15 20:43:12 PST 
Comment on attachment 329556 [details]
Patch

r=me
Comment 9 Chris Dumez 2017-12-16 08:37:17 PST 
Comment on attachment 329556 [details]
Patch

Clearing flags on attachment: 329556

Committed r225997: <https://trac.webkit.org/changeset/225997>
Comment 10 Chris Dumez 2017-12-16 08:37:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-12-16 08:40:58 PST 
<rdar://problem/36090975>