WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180880
Introduce SPI _WKWebsitePolicies.websiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=180880
Summary
Introduce SPI _WKWebsitePolicies.websiteDataStore
Alex Christensen
Reported
2017-12-15 13:37:11 PST
Introduce SPI _WKWebsitePolicies.websiteDataStore
Attachments
Patch
(17.28 KB, patch)
2017-12-15 13:42 PST
,
Alex Christensen
aestes
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2017-12-15 13:42:43 PST
Created
attachment 329515
[details]
Patch
Sam Weinig
Comment 2
2017-12-15 13:57:33 PST
Comment on
attachment 329515
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=329515&action=review
> Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h:52 > +@property (nonatomic, strong) WKWebsiteDataStore *websiteDataStore WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
It seems weird to me that something called _WKWebsitePolicies would hold onto a data store. That doesn't strike me as a policy.
Alex Christensen
Comment 3
2017-12-15 14:31:44 PST
It's kind of a policy, but you're right. This is definitely the time of navigation when we want to swap out WebsiteDataStores, though. We can rename the SPI if we want, but it needs to go in this object.
Alex Christensen
Comment 4
2017-12-15 15:14:50 PST
http://trac.webkit.org/r225989
Radar WebKit Bug Importer
Comment 5
2017-12-15 15:15:30 PST
<
rdar://problem/36083240
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug