Bug 180880 - Introduce SPI _WKWebsitePolicies.websiteDataStore
Summary: Introduce SPI _WKWebsitePolicies.websiteDataStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-15 13:37 PST by Alex Christensen
Modified: 2017-12-15 15:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (17.28 KB, patch)
2017-12-15 13:42 PST, Alex Christensen 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-12-15 13:37:11 PST 
Introduce SPI _WKWebsitePolicies.websiteDataStore
Comment 1 Alex Christensen 2017-12-15 13:42:43 PST 
Created attachment 329515 [details]
Patch
Comment 2 Sam Weinig 2017-12-15 13:57:33 PST 
Comment on attachment 329515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329515&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h:52
> +@property (nonatomic, strong) WKWebsiteDataStore *websiteDataStore WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

It seems weird to me that something called _WKWebsitePolicies would hold onto a data store.  That doesn't strike me as a policy.
Comment 3 Alex Christensen 2017-12-15 14:31:44 PST 
It's kind of a policy, but you're right.  This is definitely the time of navigation when we want to swap out WebsiteDataStores, though.  We can rename the SPI if we want, but it needs to go in this object.
Comment 4 Alex Christensen 2017-12-15 15:14:50 PST 
http://trac.webkit.org/r225989
Comment 5 Radar WebKit Bug Importer 2017-12-15 15:15:30 PST 
<rdar://problem/36083240>