CRASHING TEST: webgl/1.0.2/conformance/attribs/gl-disabled-vertex-attrib.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000017bfbfe50 WebCore::InspectorCanvas::resetRecordingData() + 416 1 com.apple.WebCore 0x000000017bfbfb13 WebCore::InspectorCanvas::~InspectorCanvas() + 19 2 com.apple.WebCore 0x000000017bff3ab8 WebCore::InspectorCanvasAgent::clearCanvasData() + 120 3 com.apple.WebCore 0x000000017bfcfd39 WebCore::InspectorInstrumentation::didCommitLoadImpl(WebCore::InstrumentingAgents&, WebCore::Frame&, WebCore::DocumentLoader*) + 217 4 com.apple.WebCore 0x000000017c05b849 WebCore::FrameLoader::dispatchDidCommitLoad(std::optional<WebCore::HasInsecureContent>) + 137 5 com.apple.WebCore 0x000000017c05b461 WebCore::FrameLoader::receivedFirstData() + 33 6 com.apple.WebCore 0x000000017c03fdeb WebCore::DocumentLoader::commitData(char const*, unsigned long) + 1627 7 com.apple.WebCore 0x000000017c03f173 WebCore::DocumentLoader::finishedLoading() + 531 ... Devin thinks we need to just not reset recording data in ~InspectorCanvas, as there is no reason to do that. I am skeptical that InspectorCanvas is not being destructed underneath ~CanvasRenderingContext, as that was the intent of the design.
<rdar://problem/36071940>
Created attachment 329503 [details] Patch
Comment on attachment 329503 [details] Patch This looks good to me. The original patch however is triggering ASSERTions on the Debug bots, so I think it is about to be rolled out. In which case this can be re-included in that when relanding.
Comment on attachment 329503 [details] Patch r=me
Comment on attachment 329503 [details] Patch Attachment 329503 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5678445 New failing tests: webgl/1.0.2/conformance/context/context-release-upon-reload.html
Created attachment 329543 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
I'm going to merge this change with <https://webkit.org/b/180770> since it has been reopened.