Bug 180870 - API test WebKit.WebsiteDataStoreCustomPaths is failing
Summary: API test WebKit.WebsiteDataStoreCustomPaths is failing
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
Keywords: InRadar
Depends on:
Reported: 2017-12-15 10:54 PST by Ryan Haddad
Modified: 2018-01-02 13:18 PST (History)
4 users (show)

See Also:

Patch (15.27 KB, patch)
2017-12-15 11:36 PST, Brady Eidson
cdumez: review+
Details | Formatted Diff | Diff
Fixed for landing (15.22 KB, patch)
2017-12-15 12:13 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-12-15 10:54:36 PST
API test WebKit.WebsiteDataStoreCustomPaths is failing on Sierra and High Sierra bots.

FAIL WebKit.WebsiteDataStoreCustomPaths

Value of: [WKWebsiteDataStore _defaultDataStoreExists]
  Actual: true
Expected: false

Comment 1 Ryan Haddad 2017-12-15 10:55:10 PST
The test started failing after https://trac.webkit.org/changeset/225789/webkit landed, and continues to fail after https://bugs.webkit.org/show_bug.cgi?id=180722
Comment 2 Brady Eidson 2017-12-15 11:36:24 PST
Created attachment 329502 [details]
Comment 3 Chris Dumez 2017-12-15 11:38:21 PST
Comment on attachment 329502 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=329502&action=review

r=me with suggestion.

> Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:66
> +    send(Messages::WebProcess::EstablishWorkerContextConnectionToStorageProcess { m_serviceWorkerPageID, store, idToUse }, 0);

initialSessionID.value_or(PAL::SessionID::defaultSessionID()) ?
Comment 4 Brady Eidson 2017-12-15 12:13:48 PST
Created attachment 329505 [details]
Fixed for landing
Comment 5 WebKit Commit Bot 2017-12-15 13:11:57 PST
Comment on attachment 329505 [details]
Fixed for landing

Clearing flags on attachment: 329505

Committed r225980: <https://trac.webkit.org/changeset/225980>
Comment 6 Radar WebKit Bug Importer 2018-01-02 13:18:24 PST