Bug 180859 - Rotating when zoomed in with fingers down can result in a broken tab
Summary: Rotating when zoomed in with fingers down can result in a broken tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-14 20:24 PST by Simon Fraser (smfr)
Modified: 2017-12-15 13:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2017-12-14 20:27 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (3.03 MB, application/zip)
2017-12-15 02:00 PST, EWS Watchlist
no flags Details
Patch (2.20 KB, patch)
2017-12-15 13:05 PST, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-12-14 20:24:53 PST
Rotating when zoomed in with fingers down can result in a broken tab
Comment 1 Simon Fraser (smfr) 2017-12-14 20:27:42 PST
Created attachment 329452 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-12-14 20:28:07 PST
rdar://problem/34532817
Comment 3 EWS Watchlist 2017-12-15 02:00:27 PST
Comment on attachment 329452 [details]
Patch

Attachment 329452 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5671180

New failing tests:
svg/custom/object-sizing-explicit-width.xhtml
Comment 4 EWS Watchlist 2017-12-15 02:00:28 PST
Created attachment 329480 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Simon Fraser (smfr) 2017-12-15 13:05:29 PST
Created attachment 329510 [details]
Patch
Comment 6 Tim Horton 2017-12-15 13:07:00 PST
Comment on attachment 329510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329510&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2381
> +    // When rotating with two fingers down, UIScrollVIew can set a bogus content view position: rdar://problem/36065495.

VIew
Comment 7 Tim Horton 2017-12-15 13:07:25 PST
Comment on attachment 329510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329510&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2382
> +    // "Center" is top left because we set the anchorPoint to 0,0.

This possibly should be a FIXME-to-remove-when-fixed?
Comment 8 Simon Fraser (smfr) 2017-12-15 13:16:11 PST
https://trac.webkit.org/r225981