Bug 180856 - Remove unnecessary boolean result of start() functions
Summary: Remove unnecessary boolean result of start() functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-14 18:51 PST by Yusuke Suzuki
Modified: 2017-12-16 09:55 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.06 KB, patch)
2017-12-16 08:19 PST, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2017-12-16 08:39 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (14.75 KB, patch)
2017-12-16 09:04 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-14 18:51:25 PST 
Remove unnecessary boolean result of start() functions
Comment 1 Yusuke Suzuki 2017-12-16 08:19:03 PST 
Created attachment 329574 [details]
Patch
Comment 2 Darin Adler 2017-12-16 08:31:01 PST 
Comment on attachment 329574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329574&action=review

> Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:-70
> -    return m_thread;

Compiler errors make it clear that we also have to turn the "return true" above into "return".
Comment 3 Yusuke Suzuki 2017-12-16 08:38:29 PST 
Comment on attachment 329574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329574&action=review

Thanks!

>> Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:-70
>> -    return m_thread;
> 
> Compiler errors make it clear that we also have to turn the "return true" above into "return".

Oops, yeah :)
Comment 4 Yusuke Suzuki 2017-12-16 08:39:42 PST 
Created attachment 329575 [details]
Patch
Comment 5 Yusuke Suzuki 2017-12-16 09:04:11 PST 
Created attachment 329576 [details]
Patch
Comment 6 Yusuke Suzuki 2017-12-16 09:54:44 PST 
Committed r225998: <https://trac.webkit.org/changeset/225998>
Comment 7 Radar WebKit Bug Importer 2017-12-16 09:55:31 PST 
<rdar://problem/36091203>