Bug 180851 – RTCController should disable ICE candidate filtering in case of getUserMedia based on the RTCPerrConnection origin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

RTCController should disable ICE candidate filtering in case of getUserMedia based on the RTCPerrConnection origin.
Currently, every frame of a capturing page gets access to unfiltered candidates.

[youenn fablet]

Created attachment 331057 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/36439701>

[EWS Watchlist]

Comment on attachment 331057 [details]
Patch

Attachment 331057 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6035760

New failing tests:
http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html

[EWS Watchlist]

Created attachment 331062 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[youenn fablet]

(In reply to Build Bot from comment #3)
> Comment on attachment 331057 [details]
> Patch
> 
> Attachment 331057 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/6035760
> 
> New failing tests:
> http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html

It should be skipped in WK1, gum is not supported there...

[youenn fablet]

Created attachment 331064 [details]
Patch

[Eric Carlson]

Comment on attachment 331064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331064&action=review

> Source/WebCore/Modules/mediastream/RTCController.cpp:90
> +void RTCController::disableICECandidateFiltering(Document& document)

Nit: maybe disableICECandidateFilteringForDocument to match the pattern of disableICECandidateFilteringForAllOrigins.

[EWS Watchlist]

Comment on attachment 331064 [details]
Patch

Attachment 331064 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6036800

New failing tests:
webgl/1.0.2/conformance/uniforms/uniform-default-values.html

[EWS Watchlist]

Created attachment 331078 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[youenn fablet]

(In reply to Build Bot from comment #8)
> Comment on attachment 331064 [details]
> Patch
> 
> Attachment 331064 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/6036800
> 
> New failing tests:
> webgl/1.0.2/conformance/uniforms/uniform-default-values.html

Error is unrelated.

[youenn fablet]

Thanks for the review.

(In reply to Eric Carlson from comment #7)
> Comment on attachment 331064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331064&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCController.cpp:90
> > +void RTCController::disableICECandidateFiltering(Document& document)
> 
> Nit: maybe disableICECandidateFilteringForDocument to match the pattern of
> disableICECandidateFilteringForAllOrigins.

OK, will do.

[youenn fablet]

Created attachment 331090 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 331090 [details]
Patch for landing

Clearing flags on attachment: 331090

Committed r226804: <https://trac.webkit.org/changeset/226804>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.