Bug 180849 – Service Worker Registration promise is sometimes not rejected when the script load fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

Service Worker Registration promise is sometimes not rejected when the script load fails.

[Chris Dumez]

Created attachment 329439 [details]
Patch

[EWS Watchlist]

Comment on attachment 329439 [details]
Patch

Attachment 329439 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5668394

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/claim-not-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/register-default-scope.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html

[EWS Watchlist]

Created attachment 329449 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329439 [details]
Patch

Attachment 329439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5668282

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/claim-not-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/register-default-scope.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html

[EWS Watchlist]

Created attachment 329450 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

(In reply to Build Bot from comment #4)
> Comment on attachment 329439 [details]
> Patch
> 
> Attachment 329439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/5668282
> 
> New failing tests:
> imported/w3c/web-platform-tests/service-workers/service-worker/claim-not-
> using-registration.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-
> other-registration.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/register-
> default-scope.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/service-
> worker-csp-default.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-
> using-registration.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/service-
> worker-csp-script.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.
> https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-
> installed.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/claim-using-
> registration.https.html
> imported/w3c/web-platform-tests/service-workers/service-worker/register-same-
> scope-different-script-url.https.html

Those failures indicate that LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/empty.js is missing, even though I included it in my patch.

It could be that git/svn is getting confused because it is an empty file? Not sure how to address this, the file does show in my patch on bugzilla.

[Chris Dumez]

Created attachment 329455 [details]
Patch

[Chris Dumez]

Created attachment 329463 [details]
Patch

[Chris Dumez]

Comment on attachment 329463 [details]
Patch

Trying an alternative proposal from Youenn.

[Chris Dumez]

Created attachment 329491 [details]
Patch

[Chris Dumez]

Created attachment 329492 [details]
Patch

[Chris Dumez]

Comment on attachment 329492 [details]
Patch

Clearing flags on attachment: 329492

Committed r225975: <https://trac.webkit.org/changeset/225975>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36078168>