RESOLVED FIXED 180832
[Web Animations] Use is<> when possible 
https://bugs.webkit.org/show_bug.cgi?id=180832
Summary [Web Animations] Use is<> when possible
Antoine Quint
Reported 2017-12-14 13:08:49 PST
[Web Animations] Use is<> when possible
Attachments
Patch (2.68 KB, patch)
2017-12-14 13:09 PST, Antoine Quint 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-12-14 13:09:24 PST
Created attachment 329389 [details] Patch
Dean Jackson
Comment 2 2017-12-14 13:10:41 PST
Comment on attachment 329389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329389&action=review > Source/WebCore/animation/WebAnimation.cpp:748 > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > + if (is<KeyframeEffect>(m_effect)) > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); Did you intend to make this change?
Antoine Quint
Comment 3 2017-12-14 13:14:10 PST
(In reply to Dean Jackson from comment #2) > Comment on attachment 329389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329389&action=review > > > Source/WebCore/animation/WebAnimation.cpp:748 > > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > > + if (is<KeyframeEffect>(m_effect)) > > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); > > Did you intend to make this change? Not with the method change name, will fix in commit.
Antoine Quint
Comment 4 2017-12-14 14:15:33 PST
Committed r225929: <https://trac.webkit.org/changeset/225929>
Radar WebKit Bug Importer
Comment 5 2017-12-14 14:16:47 PST
<rdar://problem/36058088>
Note You need to log in before you can comment on or make changes to this bug.