Bug 180832 - [Web Animations] Use is<> when possible
Summary: [Web Animations] Use is<> when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-14 13:08 PST by Antoine Quint
Modified: 2017-12-14 14:16 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2017-12-14 13:09 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-12-14 13:08:49 PST 
[Web Animations] Use is<> when possible
Comment 1 Antoine Quint 2017-12-14 13:09:24 PST 
Created attachment 329389 [details]
Patch
Comment 2 Dean Jackson 2017-12-14 13:10:41 PST 
Comment on attachment 329389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329389&action=review

> Source/WebCore/animation/WebAnimation.cpp:748
> -        downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated();
> +    if (is<KeyframeEffect>(m_effect))
> +        downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState();

Did you intend to make this change?
Comment 3 Antoine Quint 2017-12-14 13:14:10 PST 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 329389 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329389&action=review
> 
> > Source/WebCore/animation/WebAnimation.cpp:748
> > -        downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated();
> > +    if (is<KeyframeEffect>(m_effect))
> > +        downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState();
> 
> Did you intend to make this change?

Not with the method change name, will fix in commit.
Comment 4 Antoine Quint 2017-12-14 14:15:33 PST 
Committed r225929: <https://trac.webkit.org/changeset/225929>
Comment 5 Radar WebKit Bug Importer 2017-12-14 14:16:47 PST 
<rdar://problem/36058088>