Bug 180818 – Line clamp implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

Line clamp parsing

[Dave Hyatt]

Created attachment 329361 [details]
Patch

[EWS Watchlist]

Attachment 329361 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/LineClampValue.h:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 329362 [details]
Patch

[Dave Hyatt]

Created attachment 329364 [details]
Patch

[Alex Christensen]

Comment on attachment 329364 [details]
Patch

It looks like you forgot to add the actual test.  This patch only contains expectations.

[Dave Hyatt]

Created attachment 331414 [details]
Patch

[EWS Watchlist]

Attachment 331414 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLinesClampFlow.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:60:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:110:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:129:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:139:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/rendering/RenderLinesClampSet.cpp:150:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 8 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 331414 [details]
Patch

Attachment 331414 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6097390

New failing tests:
fast/overflow/line-clamp.html

[EWS Watchlist]

Created attachment 331429 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Dave Hyatt]

Created attachment 331500 [details]
Patch

[EWS Watchlist]

Comment on attachment 331500 [details]
Patch

Attachment 331500 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6107002

New failing tests:
fast/overflow/line-clamp.html

[EWS Watchlist]

Created attachment 331518 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Dave Hyatt]

Created attachment 331624 [details]
Patch

[Dave Hyatt]

Created attachment 331628 [details]
Patch

[Dave Hyatt]

Created attachment 332200 [details]
Patch

[Dean Jackson]

Comment on attachment 332200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332200&action=review

How will Mail toggle the setting? Is it already exposed as a WebPreference?

> Source/WebCore/rendering/RenderBlockFlow.cpp:3238
> +    // FIXME: Orthogonal writing modes don't work here, but it's not even clear how they should be behave anyway.

Nit: should be behave

> Source/WebCore/rendering/RenderLinesClampFlow.h:39
> +    void layout() override;

Did you need to do this, since you just call RenderMultiColumnFlow::layout()?

> Source/WebCore/rendering/RenderLinesClampSet.cpp:188
> +

Nit: remove blank line

[Dave Hyatt]

Landed in r227577.