180817 – Introduce RenderTreeBuilder

RESOLVED FIXED 180817

Introduce RenderTreeBuilder

https://bugs.webkit.org/show_bug.cgi?id=180817

Summary Introduce RenderTreeBuilder

Antti Koivisto

Reported 2017-12-14 10:12:20 PST

RenderTreeBuilder is responsible of building the render tree. Various renderer subtype specific addChild implementations will eventually move there.

Attachments
patch (108.45 KB, patch) 2017-12-14 10:21 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (110.22 KB, patch) 2017-12-14 10:37 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.95 MB, application/zip) 2017-12-14 11:34 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (3.27 MB, application/zip) 2017-12-14 11:39 PST, EWS Watchlist	no flags	Details
patch (110.35 KB, patch) 2017-12-14 11:39 PST, Antti Koivisto	zalan: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (2.35 MB, application/zip) 2017-12-14 12:53 PST, EWS Watchlist	no flags	Details
patch (112.68 KB, patch) 2017-12-14 15:14 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-elcapitan (3.14 MB, application/zip) 2017-12-14 17:37 PST, EWS Watchlist	no flags	Details
patch (114.66 KB, patch) 2017-12-15 00:45 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (589.43 KB, application/zip) 2017-12-15 01:16 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.49 MB, application/zip) 2017-12-15 01:32 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (424.05 KB, application/zip) 2017-12-15 01:35 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (700.12 KB, application/zip) 2017-12-15 01:51 PST, EWS Watchlist	no flags	Details
patch (118.22 KB, patch) 2017-12-15 01:55 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (3.81 MB, application/zip) 2017-12-15 03:27 PST, EWS Watchlist	no flags	Details
patch (118.83 KB, patch) 2017-12-16 04:56 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2017-12-14 10:15:59 PST

r=me! :)

Antti Koivisto

Comment 2 2017-12-14 10:21:18 PST

Created attachment 329359 [details] patch

Antti Koivisto

Comment 3 2017-12-14 10:37:21 PST

Created attachment 329363 [details] patch

EWS Watchlist

Comment 4 2017-12-14 11:34:30 PST

Comment on attachment 329363 [details] patch Attachment 329363 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5661702 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2017-12-14 11:34:31 PST

Created attachment 329370 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2017-12-14 11:39:11 PST

Comment on attachment 329363 [details] patch Attachment 329363 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5661493 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2017-12-14 11:39:12 PST

Created attachment 329371 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 8 2017-12-14 11:39:24 PST

Created attachment 329372 [details] patch

zalan

Comment 9 2017-12-14 12:31:28 PST

Comment on attachment 329372 [details] patch This is awesome!

EWS Watchlist

Comment 10 2017-12-14 12:53:53 PST

Comment on attachment 329372 [details] patch Attachment 329372 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5662571 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 11 2017-12-14 12:53:54 PST

Created attachment 329385 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 12 2017-12-14 15:14:51 PST

Created attachment 329407 [details] patch

Ryosuke Niwa

Comment 13 2017-12-14 15:56:11 PST

Comment on attachment 329407 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=329407&action=review > Source/WebCore/rendering/RenderTreeBuilder.h:43 > + // This is avoids having to convert all sites that need RenderTreeBuilder in one go. Nit: This avoids?

EWS Watchlist

Comment 14 2017-12-14 17:37:33 PST

Comment on attachment 329407 [details] patch Attachment 329407 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5666467 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html fast/ruby/rubyDOM-remove-rt-block-1.html webgl/1.0.2/conformance/context/context-release-upon-reload.html

EWS Watchlist

Comment 15 2017-12-14 17:37:35 PST

Created attachment 329428 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 16 2017-12-15 00:45:16 PST

Created attachment 329469 [details] patch

EWS Watchlist

Comment 17 2017-12-15 01:16:17 PST

Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5670982 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 18 2017-12-15 01:16:18 PST

Created attachment 329472 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 19 2017-12-15 01:32:52 PST

Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5671011 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 20 2017-12-15 01:32:53 PST

Created attachment 329473 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 21 2017-12-15 01:35:05 PST

Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5671095 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 22 2017-12-15 01:35:07 PST

Created attachment 329474 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 23 2017-12-15 01:51:01 PST

Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5671204 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 24 2017-12-15 01:51:03 PST

Created attachment 329478 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 25 2017-12-15 01:55:39 PST

Created attachment 329479 [details] patch

EWS Watchlist

Comment 26 2017-12-15 03:27:24 PST

Comment on attachment 329479 [details] patch Attachment 329479 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5671887 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html

EWS Watchlist

Comment 27 2017-12-15 03:27:26 PST

Created attachment 329483 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

WebKit Commit Bot

Comment 28 2017-12-15 04:35:07 PST

Comment on attachment 329479 [details] patch Clearing flags on attachment: 329479 Committed r225969: <https://trac.webkit.org/changeset/225969>

WebKit Commit Bot

Comment 29 2017-12-15 04:35:09 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2017-12-15 04:38:16 PST

<rdar://problem/36072040>

Ryan Haddad

Comment 31 2017-12-15 18:05:49 PST

Reverted r225969 for reason: This change introduced LayoutTest crashes. Committed r225994: <https://trac.webkit.org/changeset/225994>

Ryan Haddad

Comment 32 2017-12-15 18:06:13 PST

(In reply to Ryan Haddad from comment #31) > Reverted r225969 for reason: > > This change introduced LayoutTest crashes. > > Committed r225994: <https://trac.webkit.org/changeset/225994> Details and report steps in https://bugs.webkit.org/show_bug.cgi?id=180896

Ryan Haddad

Comment 33 2017-12-15 18:06:25 PST

*** Bug 180896 has been marked as a duplicate of this bug. ***

zalan

Comment 34 2017-12-15 18:32:20 PST

oh nooo!!!

Antti Koivisto

Comment 35 2017-12-16 04:56:50 PST

Created attachment 329572 [details] patch

WebKit Commit Bot

Comment 36 2017-12-16 11:07:59 PST

Comment on attachment 329572 [details] patch Clearing flags on attachment: 329572 Committed r226007: <https://trac.webkit.org/changeset/226007>

WebKit Commit Bot

Comment 37 2017-12-16 11:08:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Layout and Rendering

Assignee

Nobody

Reported

2017-12-14 10:12 PST

Modified

2017-12-16 11:08 PST History

CC List

8 users Show

URL

Keywords InRadar

Duplicates (1)

180896 View as bug list

Depends on

Blocks