Bug 180811 – [GTK] Lost session after recovering from WebProcess crashing

• Status: NEW
• Component: WebKitGTK

[Andres Gomez Garcia]

I'm using WebKitGtk+ with my own JHBuild setting:
https://github.com/tanty/jhbuild-epiphany/tree/master

Epiphany 3.24.1 and WebKit 2.19.2.

The compilation was done with CMake args:

'-DDEBUG_FISSION=OFF -DPORT=GTK -DCMAKE_BUILD_TYPE=Release -DENABLE_MINIBROWSER=ON -DUSE_WOFF2=OFF -DCMAKE_C_FLAGS_RELEASE="-O0 -g -DNDEBUG -DG_DISABLE_CAST_CHECKS -DRELEASE_WITHOUT_OPTIMIZATIONS" -DCMAKE_CXX_FLAGS_RELEASE="-O0 -g -DNDEBUG -DG_DISABLE_CAST_CHECKS -DRELEASE_WITHOUT_OPTIMIZATIONS"'

My session was a crashed version from bug 179914.

After upgrading to 2.19.3, the WebProcess doesn't crash any more, but on the first invocation of Epiphany, I noticed that my multiple tabs session is completely corrupted. Only some of the few then-selected-when-crashing tabs have been recovered. The rest of the tabs in the background have been lost to "http:///"

[Michael Catanzaro]

I'll add some more safety checks in Epiphany to avoid this resulting in a lost session.

I think the WebKit bug here is that the API request has been lost. That really should never happen, even if the web process is nonfunctional. But that's not currently the case.

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #1)
> I think the WebKit bug here is that the API request has been lost.

Specifically: I mean that after a call to webkit_web_view_load_uri(), webkit_web_view_get_uri() ought to return the URI that is supposed to be loaded, even if something has gone wrong in the web process and that has not actually happened.

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #1)
> I'll add some more safety checks in Epiphany to avoid this resulting in a
> lost session.

https://git.gnome.org/browse/epiphany/commit/?id=07ecaf9e9ed75b5f5898969bad9dd9192179b1ff