Bug 180809 - [Readable Streams API] Remove properties tests covered by WPT
Summary: [Readable Streams API] Remove properties tests covered by WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-14 06:23 PST by Romain Bellessort
Modified: 2017-12-14 09:05 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.37 KB, patch)
2017-12-14 06:41 PST, Romain Bellessort 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2017-12-14 06:23:43 PST 
Multiple RS API tests are duplicated between WebKit LayoutTests and WPT. To keep things "reviewable", I would suggest not removing too many tests from too many different files at the same time. Therefore, as a first step, I propose removing the duplicated properties tests which are found in WPT streams/readable-byte-stream/properties.js . There tests are very similar and easy to compare, hence we are sure that no test is lost. 

If this is ok, I could go on and remove other duplicated tests. To keep things "reviewable", I would suggest not
Comment 1 Romain Bellessort 2017-12-14 06:41:29 PST 
Created attachment 329352 [details]
Patch
Comment 2 Romain Bellessort 2017-12-14 06:44:31 PST 
Please note that the FIXME in the diff of readable-stream-byob-request.js is not new (it is indicated both as an addition and as a deletion).
Comment 3 WebKit Commit Bot 2017-12-14 09:04:24 PST 
Comment on attachment 329352 [details]
Patch

Clearing flags on attachment: 329352

Committed r225906: <https://trac.webkit.org/changeset/225906>
Comment 4 WebKit Commit Bot 2017-12-14 09:04:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-14 09:05:30 PST 
<rdar://problem/36048988>