Bug 180800 - WebDriver: add a common way to run tests with pytest
Summary: WebDriver: add a common way to run tests with pytest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 180420
  Show dependency tree / graph
 
Reported: 2017-12-14 03:18 PST by Carlos Garcia Campos
Modified: 2017-12-14 06:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.92 KB, patch)
2017-12-14 03:29 PST, Carlos Garcia Campos 		clopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-12-14 03:18:39 PST 
We currently use pytestrunner from wpt for w3c tests and our own code for selenium tests. Using the same code for both would simplify everything, but also allows us to have a custom results recorder to support other test expectations like TIMEOUT.
Comment 1 Carlos Garcia Campos 2017-12-14 03:29:03 PST 
Created attachment 329342 [details]
Patch
Comment 2 EWS Watchlist 2017-12-14 03:32:01 PST 
Attachment 329342 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:149:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:150:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:151:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:152:  [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'server_config' member  [pylint/E1101] [5]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2017-12-14 06:37:51 PST 
Committed r225902: <https://trac.webkit.org/changeset/225902>
Comment 4 Radar WebKit Bug Importer 2017-12-14 06:38:18 PST 
<rdar://problem/36046936>