Bug 180796 - Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally
Summary: Web Inspector: Network Tab - Make text filter just a URL filter and update in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 19:39 PST by Joseph Pecoraro
Modified: 2017-12-13 23:45 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (14.95 KB, patch)
2017-12-13 20:27 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-12-13 19:39:29 PST
Network Tab - Make text filter just a URL filter and update incrementally

Currently the text filter searches resource text content, which caused us to turn of incremental filtering because full text search is expensive. However general feedback is that the filter should update live, like other filters. So lets make the main filter a URL filter. We can find a way to add back different forms of filtering (like full text filter) later.
Comment 1 Joseph Pecoraro 2017-12-13 20:27:22 PST
Created attachment 329319 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-12-13 20:31:20 PST
<rdar://problem/35973683>
Comment 3 Brian Burg 2017-12-13 20:42:39 PST
Comment on attachment 329319 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-12-13 23:45:32 PST
Comment on attachment 329319 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 329319

Committed r225895: <https://trac.webkit.org/changeset/225895>
Comment 5 WebKit Commit Bot 2017-12-13 23:45:34 PST
All reviewed patches have been landed.  Closing bug.