Bug 180790 - logVMFailure should not simulate crash on iOS
Summary: logVMFailure should not simulate crash on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 18:10 PST by Saam Barati
Modified: 2020-11-04 10:29 PST (History)
7 users (show)

See Also:


Attachments
patch (1.34 KB, patch)
2017-12-13 19:47 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-13 18:10:48 PST
Reasons I don't think we should do this:
1. Gigacage will often fail
2. I think user controlled allocations in JS may bottom out in tryVMAllocate. Since the allocation size is often user controlled, and JS gracefully handles tryVMAllocate failing, and throws an OOM, it seems weird to consider this a crash.
Comment 1 Saam Barati 2017-12-13 19:47:50 PST
Created attachment 329313 [details]
patch

I will wait for feedback from Dave before landing since we were talking about it offline already.

An alternative patch could be to just log if the allocation is under some threshold, say 1MB or 10MB.
Comment 2 JF Bastien 2017-12-14 10:47:51 PST
Comment on attachment 329313 [details]
patch

r=me
Comment 3 Keith Miller 2017-12-14 10:49:34 PST
Comment on attachment 329313 [details]
patch

Do we want to log a failure on MacOS still?
Comment 4 Saam Barati 2017-12-14 10:51:22 PST
(In reply to Keith Miller from comment #3)
> Comment on attachment 329313 [details]
> patch
> 
> Do we want to log a failure on MacOS still?

Logging only does things for iOS. Also, I'm not convinced we ever want to log if this is a user controlled input.
Comment 5 WebKit Commit Bot 2017-12-14 11:10:58 PST
Comment on attachment 329313 [details]
patch

Clearing flags on attachment: 329313

Committed r225912: <https://trac.webkit.org/changeset/225912>
Comment 6 WebKit Commit Bot 2017-12-14 11:10:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-14 11:11:16 PST
<rdar://problem/36052852>