Reasons I don't think we should do this: 1. Gigacage will often fail 2. I think user controlled allocations in JS may bottom out in tryVMAllocate. Since the allocation size is often user controlled, and JS gracefully handles tryVMAllocate failing, and throws an OOM, it seems weird to consider this a crash.
Created attachment 329313 [details] patch I will wait for feedback from Dave before landing since we were talking about it offline already. An alternative patch could be to just log if the allocation is under some threshold, say 1MB or 10MB.
Comment on attachment 329313 [details] patch r=me
Comment on attachment 329313 [details] patch Do we want to log a failure on MacOS still?
(In reply to Keith Miller from comment #3) > Comment on attachment 329313 [details] > patch > > Do we want to log a failure on MacOS still? Logging only does things for iOS. Also, I'm not convinced we ever want to log if this is a user controlled input.
Comment on attachment 329313 [details] patch Clearing flags on attachment: 329313 Committed r225912: <https://trac.webkit.org/changeset/225912>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36052852>