Bug 180781 – Playing media elements which call "pause(); play()" will have the play promise rejected.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Playing media elements which call "pause(); play()" will have the play promise rejected.

[Jer Noble]

<rdar://problem/33191377>

[Jer Noble]

Created attachment 329280 [details]
Patch

[EWS Watchlist]

Comment on attachment 329280 [details]
Patch

Attachment 329280 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5652000

New failing tests:
media/video-interruption-with-resume-not-allowing-play.html
media/video-multiple-concurrent-playback.html
media/video-background-playback.html
media/media-controls-drag-timeline-set-controls-property.html
media/video-interruption-with-resume-allowing-play.html
media/media-playback-page-visibility.html
media/video-concurrent-playback.html

[EWS Watchlist]

Created attachment 329292 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329280 [details]
Patch

Attachment 329280 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5652367

New failing tests:
media/video-interruption-with-resume-not-allowing-play.html
media/video-multiple-concurrent-playback.html
media/video-background-playback.html
http/tests/media/hls/video-duration-accessibility.html
media/media-controls-drag-timeline-set-controls-property.html
media/video-concurrent-playback.html
http/tests/media/hls/video-controls-live-stream.html
fast/mediastream/MediaStream-video-element-displays-buffer.html
media/video-interruption-with-resume-allowing-play.html
compositing/visibility/visibility-simple-video-layer.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_playing_noautoplay.html

[EWS Watchlist]

Created attachment 329295 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329280 [details]
Patch

Attachment 329280 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5652260

New failing tests:
media/video-interruption-with-resume-not-allowing-play.html
media/controls-without-preload.html
media/video-interruption-with-resume-allowing-play.html
media/video-background-playback.html

[EWS Watchlist]

Created attachment 329297 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 329280 [details]
Patch

Attachment 329280 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5653176

New failing tests:
media/video-interruption-with-resume-not-allowing-play.html
media/video-multiple-concurrent-playback.html
media/video-background-playback.html
media/media-controls-drag-timeline-set-controls-property.html
compositing/visibility/visibility-simple-video-layer.html
media/video-interruption-with-resume-allowing-play.html
media/media-playback-page-visibility.html
media/video-concurrent-playback.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_playing_noautoplay.html

[EWS Watchlist]

Created attachment 329308 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 329498 [details]
Patch

[Eric Carlson]

Comment on attachment 329498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329498&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3501
> +        if (m_readyState <= HAVE_CURRENT_DATA)
> +            scheduleEvent(eventNames().waitingEvent);
> +        else if (m_readyState >= HAVE_FUTURE_DATA)
> +            scheduleNotifyAboutPlaying();

Nit: you should mention this fix in the ChangeLog.

[EWS Watchlist]

Comment on attachment 329498 [details]
Patch

Attachment 329498 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5675360

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html
http/tests/security/video-cross-origin-caching.html

[EWS Watchlist]

Created attachment 329506 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329498 [details]
Patch

Attachment 329498 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5675375

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html
http/tests/security/video-cross-origin-caching.html

[EWS Watchlist]

Created attachment 329507 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329498 [details]
Patch

Attachment 329498 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5675409

New failing tests:
http/tests/security/video-cross-origin-caching.html

[EWS Watchlist]

Created attachment 329508 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 329498 [details]
Patch

Attachment 329498 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5675523

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html
webgl/1.0.2/conformance/context/context-release-upon-reload.html
http/tests/security/video-cross-origin-caching.html

[EWS Watchlist]

Created attachment 329511 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 329551 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 329551 [details]
Patch for landing

Clearing flags on attachment: 329551

Committed r226059: <https://trac.webkit.org/changeset/226059>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 329551 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=329551&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3454
> +        return; // Treat as success because we will begin playback on cessation of the interruption.

This comment no longer makes much sense. Before it was explaining the reason this returned true instead of false. But what does "treat as success" mean now? I think we should just remove the comment unless we have something interesting to say here.

[Matt Lewis]

This patch caused 3 API test to start Timing out:
 RequiresUserActionForPlaybackTest.DeprecatedRequiresUserActionForVideoButNotAudioPlayback
 RequiresUserActionForPlaybackTest.RequiresUserActionForVideoButNotAudioPlayback
 WebKit.WebsitePoliciesAutoplayEnabled

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/2026

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/2026/steps/run-api-tests/logs/stdio

[Jer Noble]

Reopening to attach new patch.

[Jer Noble]

Created attachment 329764 [details]
Follow-up patch

[EWS Watchlist]

Comment on attachment 329764 [details]
Follow-up patch

Attachment 329764 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5753666

New failing tests:
media/no-autoplay-with-user-gesture-requirement.html
media/video-play-require-user-gesture.html
media/video-source-before-src.html

[EWS Watchlist]

Created attachment 329767 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329764 [details]
Follow-up patch

Attachment 329764 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5753717

New failing tests:
media/no-autoplay-with-user-gesture-requirement.html
media/video-play-require-user-gesture.html
media/video-source-before-src.html

[EWS Watchlist]

Created attachment 329770 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 329764 [details]
Follow-up patch

Attachment 329764 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5753746

New failing tests:
media/no-autoplay-with-user-gesture-requirement.html
media/video-play-require-user-gesture.html
media/video-source-before-src.html

[EWS Watchlist]

Created attachment 329772 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 329796 [details]
Follow-up patch

[EWS Watchlist]

Comment on attachment 329796 [details]
Follow-up patch

Attachment 329796 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5757553

New failing tests:
media/video-load-require-user-gesture.html

[EWS Watchlist]

Created attachment 329805 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 329814 [details]
Follow-up patch

[Jer Noble]

Created attachment 329816 [details]
Follow-up patch

[WebKit Commit Bot]

Comment on attachment 329816 [details]
Follow-up patch

Clearing flags on attachment: 329816

Committed r226150: <https://trac.webkit.org/changeset/226150>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.