currently, shorthands like border:, margin:, padding: etc don't get animated by the new -webkit-transition- feature. They need to as it is extremely common practice to use these for convenience and compact code.
Created attachment 20059 [details] test case showing the issue
Created attachment 26417 [details] Initial patch Dave, how about this approach? I just make property wrappers for shorthands that contain an array of the individual property wrappers. This works well, but it will add to the cost of running 'all' transitions.
To do: * Optimize the transition-property "all" case by avoiding shorthand wrappers, since we don't need to compare shorthands then. * Maybe reuse the ShorthandMap used for computed style.
ShorthandMap is actually in CSSMutableStyleDeclaration.
<rdar://problem/5823254>
Comment on attachment 26417 [details] Initial patch Needs more work.
Yoink.
Created attachment 26835 [details] Patch, testcases, changelog
Comment on attachment 26835 [details] Patch, testcases, changelog Everything looks fine, but you need to put CSSPropertyLonghand into its own files and add it to all the projects/makefiles please. I'll give you r=me assuming you are going to do that.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/transitions/transform-op-list-match.html M LayoutTests/transitions/transform-op-list-no-match.html M LayoutTests/transitions/transition-test-helpers.js M LayoutTests/transitions/zero-duration-in-list.html M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.pro M WebCore/WebCore.scons M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCoreSources.bkl M WebCore/css/CSSMutableStyleDeclaration.cpp A WebCore/css/CSSPropertyLonghand.cpp A WebCore/css/CSSPropertyLonghand.h M WebCore/page/animation/AnimationBase.cpp M WebCore/page/animation/AnimationBase.h M WebCore/page/animation/CompositeAnimation.cpp Committed r40039 Keeping open to commit test cases (which I left at home).
Testcases: Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/transitions/shorthand-border-transitions-expected.txt A LayoutTests/transitions/shorthand-border-transitions.html A LayoutTests/transitions/shorthand-transitions-expected.txt A LayoutTests/transitions/shorthand-transitions.html Committed r40051