Bug 180774 - Add SPI to query for the current and last auto fill button type and pass user data object to _webView:focusShouldStartInputSession:
Summary: Add SPI to query for the current and last auto fill button type and pass user...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 15:29 PST by Daniel Bates
Modified: 2017-12-18 09:14 PST (History)
6 users (show)

See Also:


Attachments
Patch and layout test (27.09 KB, patch)
2017-12-13 15:42 PST, Daniel Bates
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-12-13 15:29:13 PST
Add SPI to query for the auto fill button type and the last auto fill button type of a field.
Comment 1 Radar WebKit Bug Importer 2017-12-13 15:29:59 PST
<rdar://problem/36033832>
Comment 2 Daniel Bates 2017-12-13 15:42:47 PST
Created attachment 329273 [details]
Patch and layout test
Comment 3 Tim Horton 2017-12-15 13:04:47 PST
Comment on attachment 329273 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=329273&action=review

> Source/WebCore/html/HTMLInputElement.h:463
>      unsigned m_autoFillButtonType : 2; // AutoFillButtonType;
> +    unsigned m_lastAutoFillButtonType : 2; // AutoFillButtonType;

Why do these have trailing semicolons?
Comment 4 Daniel Bates 2017-12-18 09:13:15 PST
(In reply to Tim Horton from comment #3)
> Comment on attachment 329273 [details]
> Patch and layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329273&action=review
> 
> > Source/WebCore/html/HTMLInputElement.h:463
> >      unsigned m_autoFillButtonType : 2; // AutoFillButtonType;
> > +    unsigned m_lastAutoFillButtonType : 2; // AutoFillButtonType;
> 
> Why do these have trailing semicolons?

Will remove before landing.
Comment 5 Daniel Bates 2017-12-18 09:14:13 PST
Committed r226048: <https://trac.webkit.org/changeset/226048>