RESOLVED FIXED 180772
webkitpy: Replace Version.contained_in with Version.__contains__ 
https://bugs.webkit.org/show_bug.cgi?id=180772
Summary webkitpy: Replace Version.contained_in with Version.__contains__
Jonathan Bedard
Reported 2017-12-13 15:20:45 PST
Dean Johnson pointed out that __contains__ is more Pythonic than the function contained_in. Note that this function had to be reversed for this. self is now the container.
Attachments
Patch (5.20 KB, patch)
2017-12-13 15:26 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-13 15:21:45 PST
<rdar://problem/36033555>
Jonathan Bedard
Comment 2 2017-12-13 15:26:09 PST
Created attachment 329267 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2017-12-14 16:23:44 PST
Comment on attachment 329267 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-12-14 17:46:46 PST
Comment on attachment 329267 [details] Patch Clearing flags on attachment: 329267 Committed r225953: <https://trac.webkit.org/changeset/225953>
WebKit Commit Bot
Comment 5 2017-12-14 17:46:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.