Bug 180772 - webkitpy: Replace Version.contained_in with Version.__contains__
Summary: webkitpy: Replace Version.contained_in with Version.__contains__
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 15:20 PST by Jonathan Bedard
Modified: 2017-12-14 17:46 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2017-12-13 15:26 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-12-13 15:20:45 PST
Dean Johnson pointed out that __contains__ is more Pythonic than the function contained_in.

Note that this function had to be reversed for this.  self is now the container.
Comment 1 Radar WebKit Bug Importer 2017-12-13 15:21:45 PST
<rdar://problem/36033555>
Comment 2 Jonathan Bedard 2017-12-13 15:26:09 PST
Created attachment 329267 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2017-12-14 16:23:44 PST
Comment on attachment 329267 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-12-14 17:46:46 PST
Comment on attachment 329267 [details]
Patch

Clearing flags on attachment: 329267

Committed r225953: <https://trac.webkit.org/changeset/225953>
Comment 5 WebKit Commit Bot 2017-12-14 17:46:47 PST
All reviewed patches have been landed.  Closing bug.