Bug 180771 - Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards
Summary: Take a value driven approach to how we emit structure checks in TypeCheckHois...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 15:15 PST by Saam Barati
Modified: 2017-12-13 16:33 PST (History)
14 users (show)

See Also:

Attachments
patch (2.55 KB, patch)
2017-12-13 15:17 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-13 15:15:54 PST 
We can just check the condition we care about instead of knowing the condition to be true on 64 bit.
Comment 1 Saam Barati 2017-12-13 15:17:49 PST 
Created attachment 329266 [details]
patch
Comment 2 JF Bastien 2017-12-13 15:33:48 PST 
Comment on attachment 329266 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2017-12-13 16:32:02 PST 
Comment on attachment 329266 [details]
patch

Clearing flags on attachment: 329266

Committed r225880: <https://trac.webkit.org/changeset/225880>
Comment 4 WebKit Commit Bot 2017-12-13 16:32:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-13 16:33:47 PST 
<rdar://problem/36035713>