Bug 180766 – Only use CookieStorageShim when we aren't using NetworkSession

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Only use CookieStorageShim when we aren't using NetworkSession

[Alex Christensen]

Created attachment 329247 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 329247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329247&action=review

> Source/WebKit/ChangeLog:3
> +        Only use CookieStorageShim when we aren't using NetworkSession

Don’t we need it on 10.11 for media?

[Alex Christensen]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 329247 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329247&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Only use CookieStorageShim when we aren't using NetworkSession
> 
> Don’t we need it on 10.11 for media?

Yes we do.  That's why I enclosed it in !USE(NETWORK_SESSION).  Otherwise I would've just removed it.

[Alexey Proskuryakov]

I was unclear. What I meant to ask was, do we have platforms that use network session, but still use in-process media loading?

[Alex Christensen]

(In reply to Alexey Proskuryakov from comment #4)
> I was unclear. What I meant to ask was, do we have platforms that use
> network session, but still use in-process media loading?

No

[Brent Fulgham]

Comment on attachment 329247 [details]
Patch

Looks reasonable. Keep an eye on legacy bots after landing, please.

[Alex Christensen]

http://trac.webkit.org/r226324

[Radar WebKit Bug Importer]

<rdar://problem/36260898>