Bug 180766 - Only use CookieStorageShim when we aren't using NetworkSession
Summary: Only use CookieStorageShim when we aren't using NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 13:07 PST by Alex Christensen
Modified: 2018-01-02 12:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2017-12-13 13:09 PST, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-12-13 13:07:55 PST
Only use CookieStorageShim when we aren't using NetworkSession
Comment 1 Alex Christensen 2017-12-13 13:09:06 PST
Created attachment 329247 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-12-13 19:34:36 PST
Comment on attachment 329247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329247&action=review

> Source/WebKit/ChangeLog:3
> +        Only use CookieStorageShim when we aren't using NetworkSession

Don’t we need it on 10.11 for media?
Comment 3 Alex Christensen 2017-12-14 11:35:06 PST
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 329247 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329247&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Only use CookieStorageShim when we aren't using NetworkSession
> 
> Don’t we need it on 10.11 for media?

Yes we do.  That's why I enclosed it in !USE(NETWORK_SESSION).  Otherwise I would've just removed it.
Comment 4 Alexey Proskuryakov 2017-12-14 12:27:44 PST
I was unclear. What I meant to ask was, do we have platforms that use network session, but still use in-process media loading?
Comment 5 Alex Christensen 2017-12-21 10:28:30 PST
(In reply to Alexey Proskuryakov from comment #4)
> I was unclear. What I meant to ask was, do we have platforms that use
> network session, but still use in-process media loading?

No
Comment 6 Brent Fulgham 2017-12-28 14:07:55 PST
Comment on attachment 329247 [details]
Patch

Looks reasonable. Keep an eye on legacy bots after landing, please.
Comment 7 Alex Christensen 2018-01-02 09:18:28 PST
http://trac.webkit.org/r226324
Comment 8 Radar WebKit Bug Importer 2018-01-02 12:59:40 PST
<rdar://problem/36260898>