Bug 180756 – REGRESSION(225597): Can't select a text box or web view on a page when VO is on.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Per Arne Vollan]

We should use the NSApplication run loop until we can initialize accessibility without it.

[Per Arne Vollan]

<rdar://problem/35996158>

[Per Arne Vollan]

Created attachment 329231 [details]
Patch

[Brent Fulgham]

Comment on attachment 329231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329231&action=review

Looks good. Please address the confusing comment. r=me assuming EWS is fine.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=180756

<rdar://problem/35996158>

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:593
> +#endif

I wonder if we really need to exclude this. Surely we want to avoid calling into _AXUIElementNotify... if NSApp is not running?

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:80
> +    // Leak a boost onto the WebContent process if the NSApplication run loop is not used.

I don't know what Leak a boost" means?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 329231 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329231&action=review
> 
> Looks good. Please address the confusing comment. r=me assuming EWS is fine.
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=180756
> 
> <rdar://problem/35996158>
> 
> > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:593
> > +#endif
> 
> I wonder if we really need to exclude this. Surely we want to avoid calling
> into _AXUIElementNotify... if NSApp is not running?
> 

I excluded this in case it has some unknown performance implications.

> > Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:80
> > +    // Leak a boost onto the WebContent process if the NSApplication run loop is not used.
> 
> I don't know what Leak a boost" means?

I will change the comment before landing. Thanks for reviewing!

[Per Arne Vollan]

Committed r225863: <https://trac.webkit.org/changeset/225863/webkit>

[Simon Fraser (smfr)]

Comment on attachment 329231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329231&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests.

Why is there no explanatory text here? What did you change? Why?

[Per Arne Vollan]

(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 329231 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329231&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        No new tests.
> 
> Why is there no explanatory text here? What did you change? Why?

This patch basically reverts https://trac.webkit.org/changeset/225597/webkit, and goes back to using the NSApplication run loop, since using the NSRunLoop broke VoiceOver functionality. We will attempt to use the NSRunLoop again, when we have a way to initialize accessibility in the WebContent process.