RESOLVED FIXED 180750
[GTK] Add proxy option to Minibrowser 
https://bugs.webkit.org/show_bug.cgi?id=180750
Summary [GTK] Add proxy option to Minibrowser
Nael Ouedraogo
Reported 2017-12-13 07:20:13 PST
Add proxy option to Minibrowser.
Attachments
Patch (2.91 KB, patch)
2017-12-13 08:19 PST, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2017-12-15 01:12 PST, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2017-12-15 01:47 PST, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-elcapitan (2.94 MB, application/zip)
2017-12-15 03:08 PST, EWS Watchlist 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nael Ouedraogo
Comment 1 2017-12-13 08:19:38 PST
Created attachment 329218 [details] Patch
Michael Catanzaro
Comment 2 2017-12-13 08:54:41 PST
Comment on attachment 329218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329218&action=review > Tools/MiniBrowser/gtk/main.c:108 > + { "ignore-host", 0, 0, G_OPTION_ARG_STRING_ARRAY, &ignoreHosts, "Set proxy ignore hosts", "HOST" }, HOSTS
Nael Ouedraogo
Comment 3 2017-12-15 01:12:05 PST
Created attachment 329471 [details] Patch
Nael Ouedraogo
Comment 4 2017-12-15 01:47:40 PST
Created attachment 329477 [details] Patch
Nael Ouedraogo
Comment 5 2017-12-15 01:48:16 PST
Thanks for the review.
EWS Watchlist
Comment 6 2017-12-15 03:08:50 PST
Comment on attachment 329477 [details] Patch Attachment 329477 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5671814 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html webgl/1.0.2/conformance/context/context-release-upon-reload.html
EWS Watchlist
Comment 7 2017-12-15 03:08:51 PST
Created attachment 329482 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Nael Ouedraogo
Comment 8 2017-12-15 06:06:59 PST
The test failure on mac-debug is not related to this patch.
WebKit Commit Bot
Comment 9 2017-12-15 06:27:29 PST
Comment on attachment 329477 [details] Patch Clearing flags on attachment: 329477 Committed r225972: <https://trac.webkit.org/changeset/225972>
WebKit Commit Bot
Comment 10 2017-12-15 06:27:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-12-15 06:28:21 PST
<rdar://problem/36072771>
Note You need to log in before you can comment on or make changes to this bug.