Bug 180738 - InferredValue should use IsoSubspace
Summary: InferredValue should use IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-12 21:21 PST by Filip Pizlo
Modified: 2017-12-14 07:49 PST (History)
8 users (show)

See Also:

Attachments
the patch (17.29 KB, patch)
2017-12-12 21:24 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (17.59 KB, patch)
2017-12-13 13:19 PST, Filip Pizlo 		keith_miller: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.59 MB, application/zip)
2017-12-13 14:39 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-12-12 21:21:48 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-12-12 21:24:28 PST 
Created attachment 329202 [details]
the patch
Comment 2 Filip Pizlo 2017-12-13 13:19:09 PST 
Created attachment 329250 [details]
the patch
Comment 3 Keith Miller 2017-12-13 13:43:00 PST 
Comment on attachment 329250 [details]
the patch

r=me.
Comment 4 EWS Watchlist 2017-12-13 14:39:48 PST 
Comment on attachment 329250 [details]
the patch

Attachment 329250 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5649442

New failing tests:
webrtc/video-replace-muted-track.html
Comment 5 EWS Watchlist 2017-12-13 14:39:49 PST 
Created attachment 329260 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Filip Pizlo 2017-12-13 17:11:08 PST 
(In reply to Build Bot from comment #4)
> Comment on attachment 329250 [details]
> the patch
> 
> Attachment 329250 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5649442
> 
> New failing tests:
> webrtc/video-replace-muted-track.html

Seems totally unrelated.
Comment 7 Filip Pizlo 2017-12-13 17:12:20 PST 
Landed in https://trac.webkit.org/changeset/225887/webkit
Comment 8 Radar WebKit Bug Importer 2017-12-13 17:13:19 PST 
<rdar://problem/36036823>
Comment 9 David Kilzer (:ddkilzer) 2017-12-14 07:37:08 PST 
(In reply to Filip Pizlo from comment #7)
> Landed in https://trac.webkit.org/changeset/225887/webkit

Attempt to fix the build:

https://trac.webkit.org/changeset/225903/webkit
Comment 10 David Kilzer (:ddkilzer) 2017-12-14 07:49:28 PST 
(In reply to David Kilzer (:ddkilzer) from comment #9)
> (In reply to Filip Pizlo from comment #7)
> > Landed in https://trac.webkit.org/changeset/225887/webkit
> 
> Attempt to fix the build:
> 
> https://trac.webkit.org/changeset/225903/webkit

The broken builds were on internal iOS hardware (arm64) buildbots.