Bug 180734 - TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
Summary: TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 180764
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-12 19:20 PST by Saam Barati
Modified: 2017-12-13 12:48 PST (History)
16 users (show)

See Also:


Attachments
patch (5.13 KB, patch)
2017-12-12 19:28 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-12 19:20:15 PST
Because |this| can be TDZ. This doesn't happen at a function's call entrypoint, but it can happen at a catch entry point.
Comment 1 Saam Barati 2017-12-12 19:20:48 PST
<rdar://problem/35640547>
Comment 2 Saam Barati 2017-12-12 19:28:47 PST
Created attachment 329194 [details]
patch
Comment 3 Yusuke Suzuki 2017-12-13 00:25:28 PST
Comment on attachment 329194 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2017-12-13 09:19:27 PST
Comment on attachment 329194 [details]
patch

Clearing flags on attachment: 329194

Committed r225844: <https://trac.webkit.org/changeset/225844>
Comment 5 WebKit Commit Bot 2017-12-13 09:19:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Alberto Lopez Perez 2017-12-13 11:54:34 PST
(In reply to WebKit Commit Bot from comment #4)
> Comment on attachment 329194 [details]
> patch
> 
> Clearing flags on attachment: 329194
> 
> Committed r225844: <https://trac.webkit.org/changeset/225844>

It seems this did cased like 900 test failures on 32-bit?

Results for r225843 (74 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267
Results for r225844 (904 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268
Comment 7 Carlos Alberto Lopez Perez 2017-12-13 12:06:36 PST
(In reply to Carlos Alberto Lopez Perez from comment #6)
> (In reply to WebKit Commit Bot from comment #4)
> > Comment on attachment 329194 [details]
> > patch
> > 
> > Clearing flags on attachment: 329194
> > 
> > Committed r225844: <https://trac.webkit.org/changeset/225844>
> 
> It seems this did cased like 900 test failures on 32-bit?
> 
> Results for r225843 (74 JSC test failed)
> https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267
> Results for r225844 (904 JSC test failed)
> https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268

Reported in bug 180764
Comment 8 Saam Barati 2017-12-13 12:25:15 PST
(In reply to Carlos Alberto Lopez Perez from comment #7)
> (In reply to Carlos Alberto Lopez Perez from comment #6)
> > (In reply to WebKit Commit Bot from comment #4)
> > > Comment on attachment 329194 [details]
> > > patch
> > > 
> > > Clearing flags on attachment: 329194
> > > 
> > > Committed r225844: <https://trac.webkit.org/changeset/225844>
> > 
> > It seems this did cased like 900 test failures on 32-bit?
> > 
> > Results for r225843 (74 JSC test failed)
> > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267
> > Results for r225844 (904 JSC test failed)
> > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268
> 
> Reported in bug 180764

Thanks will look in a few.
Comment 9 Saam Barati 2017-12-13 12:48:01 PST
Fixed in:
https://trac.webkit.org/changeset/225865/webkit