Bug 180726 - Unify some WebGL sources
Summary: Unify some WebGL sources
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2017-12-12 16:31 PST by Dean Jackson
Modified: 2017-12-13 10:36 PST (History)
10 users (show)

See Also:

Patch (35.62 KB, patch)
2017-12-12 16:33 PST, Dean Jackson
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-12-12 16:31:50 PST
Unify some WebGL sources
Comment 1 Dean Jackson 2017-12-12 16:33:49 PST
Created attachment 329177 [details]
Comment 2 WebKit Commit Bot 2017-12-12 16:35:29 PST
Comment on attachment 329177 [details]

Rejecting attachment 329177 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 329177, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Keith, weeks ago found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/5637991
Comment 3 Dean Jackson 2017-12-12 19:52:02 PST
Committed r225836: <https://trac.webkit.org/changeset/225836>
Comment 4 Radar WebKit Bug Importer 2017-12-12 19:53:43 PST
Comment 5 Ryan Haddad 2017-12-13 10:31:00 PST
As EWS predicted, this change broke the Windows build:
Comment 6 Ryan Haddad 2017-12-13 10:36:30 PST
Reverted r225836 for reason:

Broke the Windows build.

Committed r225854: <https://trac.webkit.org/changeset/225854>